Skip to content

Conversation

@major
Copy link
Contributor

@major major commented Apr 11, 2022

Description

The jsondiff package was recently updated and a 2.0.0 version was released. I'd like to update my python3-jsondiff Fedora package to 2.0.0, but azure-cli demands a version >= 1.3 and <= 1.4.

For completeness, the bug on the Fedora side is BZ 2073817.

Testing Guide

All testing processes should remain the same.


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 11, 2022
@ghost
Copy link

ghost commented Apr 11, 2022

Thank you for your contribution major! We will review the pull request and get back to you soon.

@ghost ghost requested review from jiasli, kairu-ms, wangzelin007 and yonzhan April 11, 2022 13:49
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 11, 2022
@ghost ghost assigned jiasli Apr 11, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 11, 2022
@ghost ghost added the Packaging label Apr 11, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 11, 2022

packaging

@jiasli
Copy link
Member

jiasli commented Apr 12, 2022

jsondiff is used by appconfig:

@shenmuxiaosen @avanigupta @zhoxing-ms @jsntcy, please help verify if the latest jsondiff works as expected.

@yonzhan yonzhan requested a review from zhoxing-ms April 12, 2022 01:14
@jiasli
Copy link
Member

jiasli commented May 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jiasli jiasli merged commit 55299d5 into Azure:dev May 19, 2022
@jiasli
Copy link
Member

jiasli commented May 19, 2022

I have merged the PR. Thanks @major.

@major major deleted the update-jsondiff branch May 19, 2022 11:46
@major
Copy link
Contributor Author

major commented May 19, 2022

I have merged the PR. Thanks @major.

You're welcome. Thank you for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants