[ARM] az resource wait: Fix --created keeps waiting even when az resource show returns "provisioningState": "Succeeded"
#22254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
added
the
ARM
Collaborator
|
ARM |
zhoxing-ms
force-pushed
the
fix_resource_wait
branch
from
dccfdc0 to
fd8b67d
Compare
zhoxing-ms
requested review from
calvinhzy,
evelyn-ys,
jiasli,
jsntcy and
kairu-ms
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
wangzelin007
approved these changes
May 18, 2022
kairu-ms
reviewed
May 18, 2022
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
kairu-ms
reviewed
May 18, 2022
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
kairu-ms
reviewed
May 18, 2022
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: kai ru <[email protected]>
kairu-ms
approved these changes
May 18, 2022
jsntcy
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When executing
az resource waitcommand, calling_get_provisioning_state()method can't get provisioning_state.code link: command_operation.py
Because
instance.propertiesisdicttype at this time, so it can only be obtained throughinstance.properties['provisioningState']In addition, this problem has existed since very early CLI versions and even it may never worked correctly before (there had been no related scenario tests). I even tried the
2.23.0version of CLI, which relies on the Track 1 Python SDK, this problem can still be reproduced.Therefore, this is a very old legacy problem, so I submitted this PR to add correct parsing logic to method
_get_provisioning_state()Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
[x ] I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.