[Compute] az sig show: Add new parameters --sharing-groups to support query shared gallery group
#22371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jing-song
requested review from
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms and
wangzelin007
as code owners
ghost
requested a review
from 
ghost
added
the
Collaborator
|
Compute |
zhoxing-ms
reviewed
May 13, 2022
| ]) | ||
|
|
||
| self.cmd('sig show -g {rg} -r {gallery_name}', checks=[ | ||
| self.cmd('sig show -g {rg} -r {gallery_name} --expand sharingProfile/Groups', checks=[ |
Contributor
There was a problem hiding this comment.
I recommend using the independent parameter --sharing-groups instead of directly asking users to enter --expand sharingProfile/Groups, because the meaning of this parameter is clearer (we can add help information for this parameter) and more convenient for users to input. @kangsun-ctrl What do you think of it?
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Jing-song
changed the title
az sig show: Add new parameters --expand to support query shared galleryaz sig show: Add new parameters --sharing-groups to support query shared gallery group
zhoxing-ms
reviewed
May 18, 2022
zhoxing-ms
reviewed
May 18, 2022
zhoxing-ms
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Shared gallery replace '--seletct=permissions' with '--expand=sharingProfile/Groups' #22327
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.