[AKS] Fix #22032: az aks nodepool add/update: Fix autoscaler parameters for user node pools

[PramodValavala-MSFT]

Related command

az aks nodepool add
az aks nodepool update

Description

This PR address 2 changes

• Node Pools can be scaled from 0 to 1000 nodes from the Azure Portal, but the CLI has a check restricting them between 1 and 100
• Only User Node Pools support scaling to 0 nodes, which after the fix for the acceptable range above, results in unintuitive error messages from the ARM endpoint

After the fix for the first, the following commands were tested, resulting in errors from ARM as below

# Creating a System Node Pool with Min Count set to 0 and Node Count set to 0
$ az aks nodepool add --name {} --cluster-name {} --resource-group {} --enable-cluster-autoscaler --node-count 0 --min-count 0 --max-count 1 --mode System
(InvalidParameter) The value of parameter agentPoolProfile.count is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Code: InvalidParameter
Message: The value of parameter agentPoolProfile.count is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Target: agentPoolProfile.count

# Creating a System Node Pool with Min Count set to 0 and Node Count set to 1
$ az aks nodepool add --name {} --cluster-name {} --resource-group {} --enable-cluster-autoscaler --node-count 1 --min-count 0 --max-count 1 --mode System
(InvalidParameter) The value of parameter agentPoolProfile.minCount is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Code: InvalidParameter
Message: The value of parameter agentPoolProfile.minCount is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Target: agentPoolProfile.minCount

# Updating a System Node Pool to have Min Count set to 0
$ az aks nodepool update --name {} --cluster-name {} --resource-group {} --update-cluster-autoscaler --min-count 0 --max-count 1
(InvalidParameter) The value of parameter agentPoolProfile.minCount is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Code: InvalidParameter
Message: The value of parameter agentPoolProfile.minCount is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Target: agentPoolProfile.minCount

# Updating a User Node Pool to a System Node Pool with Min Count set to 0
$ az aks nodepool update --name {} --cluster-name {} --resource-group {} --update-cluster-autoscaler --min-count 0 --max-count 1 --mode System
(InvalidParameter) The value of parameter agentPoolProfile.minCount is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Code: InvalidParameter
Message: The value of parameter agentPoolProfile.minCount is invalid. Please see https://aka.ms/aks-naming-rules for more details.
Target: agentPoolProfile.minCount

With the other set of changes in this PR, all of the above commands will result in the following error instead

Value of min-count should be greater than or equal to 1 for System node pools

resolves #22032
resolves #22438

Testing Guide

Run the commands mentioned above

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[yonzhan]

AKS

[andyliuliming]

will approve this after @FumingZhang add one more live test case.

[FumingZhang]

Here's the PR #22451 to add live test cases. Will update recordings after this PR is merged.

[zhoxing-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).