Skip to content

vm image list command: surface exceptions from thread pool #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yugangw-msft merged 1 commit into from
May 9, 2016
Merged

vm image list command: surface exceptions from thread pool #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@ def _load_images_from_aliases_doc(publisher, offer, sku):
raise CLIError('Could not retrieve image list from {}'.format(target_url))

def _load_images_thru_services(publisher, offer, sku, location):
from concurrent.futures import ThreadPoolExecutor
from concurrent.futures import ThreadPoolExecutor, as_completed

all_images = []
client = _compute_client_factory({})
all_images = []

def _load_images_from_publisher(publisher):
offers = client.virtual_machine_images.list_offers(location, publisher)
Expand All @@ -171,8 +171,9 @@ def _load_images_from_publisher(publisher):
publisher_num = len(publishers)
if publisher_num > 1:
with ThreadPoolExecutor(max_workers=40) as executor:
for p in publishers:
executor.submit(_load_images_from_publisher, p.name)
tasks = [executor.submit(_load_images_from_publisher, p.name) for p in publishers]
for t in as_completed(tasks):
t.result() #we don't use the result, rather just to expose exceptions from threads
elif publisher_num == 1:
_load_images_from_publisher(publishers[0].name)

Expand Down