{Role} Raise GraphError only when Graph request fails

[jiasli]

Related command
az ad

Description

Currently, all subclasses of CLIError are re-raised as GraphError. This is not correct and causes failure for AuthenticationError handling.

For example, we change microsoft_graph_resource_id to an invalid value like https://graph1.microsoft.com/, which is then used as a scope to get an access token:

azure-cli/src/azure-cli-core/azure/cli/core/cloud.py

Line 308 in 31e396b

microsoft_graph_resource_id='https://graph.microsoft.com/',

The error handling procedure failed:

 > az ad app show --id 0e33fcf1-8a78-4941-9479-75d29681f4dc
...
    result = self._send("GET", "/applications" + _filter_to_query(filter))
  File "d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\role\msgrpah\_graph_client.py", line 40, in _send
    raise GraphError(ex.response.json()['error']['message'], ex.response) from ex
AttributeError: 'AuthenticationError' object has no attribute 'response'

This PR makes send_raw_request raise a dedicated error HTTPError and it is then re-raised as GraphError. Since HTTPError is a sub-class of CLIError, it is backward compatible.

Now invalid scope will result in

> az ad app show --id 0e33fcf1-8a78-4941-9479-75d29681f4dc
This command or command group has been migrated to Microsoft Graph API. Please carefully review all breaking changes introduced during this migration: https://docs.microsoft.com/cli/azure/microsoft-graph-migration
AADSTS500011: The resource principal named https://graph1.microsoft.com/ was not found in the tenant named AzureSDKTeam. This can happen if the application has not been installed by the administrator of the tenant or consented to by any user in the tenant. You might have sent your authentication request to the wrong tenant.
Trace ID: 4afc0638-c613-4eba-8556-0031e7c8a500
Correlation ID: 17b08664-450c-41fa-a69b-09002c9d5c4d
Timestamp: 2022-05-19 06:52:07Z
To re-authenticate, please run:
az login --scope https://graph1.microsoft.com//.default

[jiasli]

Alternative names can be RequestError or RawRequestError. I chose this name similar to requests.exceptions.HTTPError.

[yonzhan]

Role