[Service Fabric] az sf managed-cluster create: Fix tag parsing for cluster command
#22752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
LukeSlev
force-pushed
the
uset/luslevin/update-cluster-tags
branch
from
f6ad7f2 to
3f71f4f
Compare
LukeSlev
force-pushed
the
uset/luslevin/update-cluster-tags
branch
from
3f71f4f to
2b0d612
Compare
Collaborator
|
Service Fabric |
a-santamaria
approved these changes
Jun 8, 2022
zhoxing-ms
approved these changes
Jun 8, 2022
zhoxing-ms
changed the title
az sf managed-cluster create: Fix tag parsing for cluster command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
az sf managed-cluster
Description
This PR fixes tags for managed cluster commands. It turns out if a with argument context block has a validator defined, child arguments within the block don't get their validators run, so this is explicitly validating tags which parses them into a dict from a list
Testing Guide
History Notes
{Service Fabric}
az sf managed-cluster create: Make tags workThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.