[ACR] Add new soft-delete commands #22959
Conversation
upstream dev to main
main into dev
mabenedi
requested review from
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms and
zhoxing-ms
as code owners
ghost
requested review from
ghost
assigned
mabenedi
changed the title
|
@yonzhan @zhoxing-ms We're ready to take this PR out of draft and get it reviewed and merged before the code complete on Aug 31. If we could remove the do not merge tag and review we would appreciate it |
zhoxing-ms
changed the title
...cli/azure/cli/command_modules/resource/tests/latest/recordings/test_tag_update_by_patch.yaml
Outdated
Show resolved
Hide resolved
Could you refer to this PR #23323 to add detailed description to these new commands in history notes? It is better to describe the feature of those new commands clearly |
This will cause breaking change to users, right? If so, I suggest splitting this part into a separate PR, and then merge this part and release it in the next sprint. Because the next sprint is Ignite Event, which is our annual breaking change window, we will uniformly release breaking change during this time period. |
I'm not sure. These commands have been hidden/deprecated for months now |
done |
@mabenedi This should be a breaking change, because it still breaks the automated scripts which use it. Please submit a PR separately, and we will merge and release this part in Ignite Event. |
Done, will send other PR separately. Still trying to merge this before code complete this milestone |
| self.check('length(@)', 1)]) | ||
|
|
||
| @ResourceGroupPreparer(location='centraluseuap') | ||
| @ResourceGroupPreparer(location='centralus') |
There was a problem hiding this comment.
Just out of curiosity, why do you modify this location for the network module related tests?
There was a problem hiding this comment.
Because it said that centraluseuap was an unsupported region when I ran the test
...cli/azure/cli/command_modules/resource/tests/latest/recordings/test_tag_update_by_patch.yaml
Outdated
Show resolved
Hide resolved
4 participants
Description
config soft-delete update,config soft-delete show,repository list-deleted,manifest list-deleted,manifest list-deleted-tags,manifest restoresubnetandvnet-nameonnetwork-rulecommand groupacr configcommands that would in certain circumstances attempt to pull a nonexistent model from SDK---History Notes
[ACR]
az acr config soft-delete show: Add new command to show soft-delete policy[ACR]
az acr config soft-delete update: Add new command to update soft-delete policy[ACR]
az acr repository list-deleted: Add new command to list deleted repositories[ACR]
az acr manifest list-deleted: Add new command to list deleted manifests[ACR]
az acr manifest list-deleted-tags: Add new command to list deleted tags[ACR]
az acr manifest restore: Add new command to restore deleted manifests and tags[ACR] Deprecate params
subnetandvnet-nameonnetwork-rulecommand group[ACR] Fix bug in some
acr configcommands that would in certain circumstances attempt to pull a nonexistent model from SDKThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.