[AKS] support csi drivers extensibility #23654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroMagic
requested review from
andyliuliming,
jsntcy and
zhoxing-ms
as code owners
ghost
requested a review
from 
ghost
assigned
Collaborator
|
AKS |
FumingZhang
reviewed
Aug 25, 2022
cvvz
approved these changes
Aug 25, 2022
FumingZhang
reviewed
Aug 25, 2022
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Ji An Liu <[email protected]>
Contributor
Author
|
Could you have a look @zhoxing-ms |
zhoxing-ms
reviewed
Aug 26, 2022
Contributor
|
Could you write the history notes for the feature of these new parameters in the PR description like #23324 |
Contributor
Author
Updated the description |
zhoxing-ms
approved these changes
Aug 30, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create [--disable-disk-driver] [--disable-file-driver] [--disable-snapshot-controller]
az aks update [--disable-disk-driver] [--disable-file-driver] [--disable-snapshot-controller] [--enable-disk-driver] [--enable-file-driver] [--enable-snapshot-controller]
Description
With the feature, customers can enable/disable the CSI Drivers in their clusters according to demand.
Testing Guide
pyttest test_managed_cluster_decorator.py
azdev test acs.test_aks_create_and_update_with_csi_drivers_extensibility --live
azdev test acs.test_aks_create_with_standard_csi_drivers --live
History Notes
[AKS]
az aks create/update: Add new parameters--enable-disk-driverand--disable-disk-driverto enable/disable AzureDisk CSI Driver. When creating new cluster, AzureDisk CSI Driver is enabled by default.[AKS]
az aks create/update: Add new parameters--enable-file-driverand--disable-file-driverto enable/disable AzureFile CSI Driver. When creating new cluster, AzureFile CSI Driver is enabled by default.[AKS]
az aks create/update: Add new parameters--enable-snapshot-controllerand--disable-snapshot-controllerto enable/disable CSI Snapshot Controller. When creating new cluster, CSI Snapshot Controller is enabled by default.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.