Skip to content

[Packaging] Support Windows ZIP package #27911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bebound merged 21 commits into from
Jan 30, 2024
Merged

[Packaging] Support Windows ZIP package #27911

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
452a3dc
Init
bebound Nov 24, 2023
181d34b
Beta test
bebound Nov 24, 2023
2125e39
Minor fix
bebound Nov 27, 2023
74aa576
Add test
bebound Nov 27, 2023
fda9040
Minor fix
bebound Nov 28, 2023
33b2cf7
Add test
bebound Nov 28, 2023
79e3c18
Use 7z
bebound Nov 30, 2023
ef1f743
Add upgrade
bebound Nov 30, 2023
d926724
Minor fix
bebound Nov 30, 2023
72667ad
Minor fix
bebound Dec 4, 2023
deb94ac
Use LZMA
bebound Dec 6, 2023
7ed5497
Minor fix
bebound Dec 11, 2023
63207d3
Add azps_zip.ps1
bebound Jan 5, 2024
6fa7aa4
Remove x86
bebound Jan 15, 2024
0956882
Minor fix
bebound Jan 17, 2024
52552df
Minor fix
bebound Jan 17, 2024
3e6f1b5
Minor fix
bebound Jan 17, 2024
dd0f8bc
Merge branch 'dev' into zip
bebound Jan 17, 2024
95264cd
Remove root folder, use bin folder
bebound Jan 22, 2024
ac32b2d
MInor fix
bebound Jan 23, 2024
6fb6c8e
MInor fix
bebound Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MInor fix
  • Loading branch information
@bebound
bebound committed Jan 23, 2024
commit 6fb6c8ef0fb056bf58799f691dbcaf73ecaff31b
2 changes: 1 addition & 1 deletion build_scripts/windows/scripts/build.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ REM Remove pywin32 help file to reduce size.
del %BUILDING_DIR%\Lib\site-packages\PyWin32.chm

if "%TARGET%"=="msi" (
echo Creating the wbin (Windows binaries) folder that will be added to the path...
REM Creating the wbin (Windows binaries) folder that will be added to the path...
Copy link
Contributor Author

@bebound bebound Jan 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I use echo instead of REM, the (Windows binaries) folder will be parsed and folder was unexpected at this time. error will be raised. It seems there are some special rules when parentheses block is executed.
Repro script:

echo () ok
if 'kk'=='kk' (
    echo () ok2
)
() ok
ok2 was unexpected at this time.

Copy link
Member

@jiasli jiasli Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you truly need to use echo, you may quote the sentence:

echo "Creating the wbin (Windows binaries) folder that will be added to the path..."

Copy link
Contributor Author

@bebound bebound Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. (Generally, echo is able to print multiple word without the quote: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/echo)

In this instance, since the line functions more as a comment, so I changed it to REM.

mkdir %BUILDING_DIR%\wbin
copy %REPO_ROOT%\build_scripts\windows\scripts\az_msi.cmd %BUILDING_DIR%\wbin\az.cmd
copy %REPO_ROOT%\build_scripts\windows\scripts\azps.ps1 %BUILDING_DIR%\wbin\
Expand Down