Skip to content

[Storage] az storage file copy start: Fix when copying between two storage accounts and source file has no parent directory #28123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinhzy merged 3 commits into from
Jan 18, 2024
Merged

[Storage] az storage file copy start: Fix when copying between two storage accounts and source file has no parent directory #28123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
206d23d
fix `az storage file copy start` with source file with no parent dire…
calvinhzy Jan 3, 2024
c0c5f97
add tests for copy file between different storage accounts, and case …
calvinhzy Jan 12, 2024
723e83a
remove sas token for credscan
calvinhzy Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/azure-cli/azure/cli/command_modules/storage/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,8 @@ def validate_source_uri(cmd, namespace): # pylint: disable=too-many-statements
prefix = cmd.command_kwargs['resource_type'].value[0]
if valid_file_source and (ns.get('container_name', None) or not same_account):
dir_name, file_name = os.path.split(path) if path else (None, '')
if dir_name == '':
dir_name = None
if is_storagev2(prefix):
source_sas = create_short_lived_file_sas_v2(cmd, source_account_name, source_account_key, share,
dir_name, file_name)
Expand Down
Loading