-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[App Service] az webapp create: Add new parameter --acr-use-identity to configure pull image from ACR using MSI when creating a container web app
#28209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhoxing-ms
merged 1 commit into
Azure:dev
from
mstxsun:feature-add-acr-use-managed-identity-creds
Jan 18, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using MSI when creating a container web app
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| webapp create | cmd webapp create added parameter acr_use_identity |
Collaborator
|
App Service |
jvano
approved these changes
Jan 17, 2024
jvano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
zhoxing-ms
approved these changes
Jan 18, 2024
az webapp create Add new parameter --acr-use-identity to configure pull image from ACR using MSI when creating a container web appaz webapp create: Add new parameter --acr-use-identity to configure pull image from ACR using MSI when creating a container web app
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
…to configure pull image from ACR using MSI when creating a container web app (Azure#28209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp createDescription
Add new parameter
--acr-use-identityto configure pull image from ACR using MSI when creating a container web app. It allows user to update siteconfig acrUseManagedIdentityCreds while creating webapp, this can significantly reduce steps user needs to have to create a container webapp which pulls image from ACR using MSI.Testing Guide
az webapp createcommand with and without--acr-use-identityto make sure webapp can be created successfully with new parameter also changes don't break webapp creation without this new parameter. And check the config of new created webapp by usingaz webapp config showto make sure siteconfig acrUseManagedIdentityCreds is updated as expected.az webapp createwith this parameterHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.