[Storage] Fix #28202: az storage container policy create: Fix creating an access policy would delete public access permission
#28211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l need to fix for share queue table
calvinhzy
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Storage |
calvinhzy
changed the title
az storage container policy create Fix where it deletes public access infoaz storage container policy create: Fix creating an access policy would delete public access permission
evelyn-ys
approved these changes
Jan 18, 2024
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
…creating an access policy would delete public access permission (Azure#28211) * fix container policy create where it deletes public access info, still need to fix for share queue table * move container access policy to new file as format is different * fix container set-permission where it would fail with an access policy already set * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix #28202
[Storage] Fix #28202:
az storage container policy create: Fix creating an access policy would delete public access permission[Storage]
az storage container set-permission: Fix failing when updating public access permission with an existing access policyTesting Guide
History Notes
[Storage] Fix #28202:
az storage container policy create: Fix creating an access policy would delete public access permission[Storage]
az storage container set-permission: Fix failing when updating public access permission with an existing access policyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.