{ACR} Hotfix: Revert polling change #30482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add githooks * fix src and tgt * Add rebase check * add rebase check * Add rebase upstream/dev warning. * Using merge base as target * test * print the warning again * +x for hooks * Replace echo with printf * fix printf * remove line for test * Improve the code for tests * Add docs for .githooks * use medium min-servity for azdev linter.
* remove existing creds from test recordings * fix azure stack * revert unnecessary change * fix appservice * revert unnecessary changes for acs
nguyenm2151
requested review from
AllyW,
bebound,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
|
Hi @nguyenm2151, |
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
Auto-Assign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az acr agentpool delete
Description
Revert some changes from this PR #30195 since we found an regression. Found an issue with self.cmd not detecting a command failure in this case. #30478
Testing Guide
acr agentpool delete -n {agents_name} -r {registry_name} -y
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.