{Auth} Support get_token_info protocol
#30928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
jiasli
commented
Mar 3, 2025
| return None | ||
|
|
||
|
|
||
| def _generate_msal_kwargs(options=None): |
Member
Author
There was a problem hiding this comment.
Unifying the msal_kwargs generation logic also fixes the claims argument for get_token (#30062 (comment)).
jiasli
commented
Mar 4, 2025
Comment on lines
+60
to
+63
| # For VM SSH. 'data' support is a CLI-specific extension. | ||
| # SDK doesn't support 'data': https://github.com/Azure/azure-sdk-for-python/pull/16397 | ||
| if 'data' in options: | ||
| msal_kwargs['data'] = options['data'] |
Member
Author
There was a problem hiding this comment.
data is currently only officially used by ssh extension:
credential, _, _ = profile.get_login_credentials(subscription_id=profile.get_subscription()["id"])
certificatedata = credential.get_token(*scopes, data=data)
jiasli
commented
Mar 12, 2025
| self._credential = credential | ||
| self._auxiliary_credentials = auxiliary_credentials | ||
|
|
||
| def get_token(self, *scopes, **kwargs): |
Member
Author
There was a problem hiding this comment.
get_token is kept as ssh extension still direclty uses it to get an SSH certificate:
credential, _, _ = profile.get_login_credentials(subscription_id=profile.get_subscription()["id"])
certificatedata = credential.get_token(*scopes, data=data)
certificate = certificatedata.token
jiasli
commented
Mar 12, 2025
| return msal_kwargs | ||
|
|
||
|
|
||
| def _build_sdk_access_token_info(token_entry): |
Member
Author
There was a problem hiding this comment.
build_sdk_access_token is still used by azure.cli.core.auth.adal_authentication.MSIAuthenticationWrapper.get_token:
so it can't be moved to src/azure-cli-core/azure/cli/core/auth/credential_adaptor.py right now.
bebound
approved these changes
Mar 18, 2025
evelyn-ys
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
Require #29955
Close #29967
Support the new
get_token_infoprotocol introduced byazure-core1.31.0 (Azure/azure-sdk-for-python#36565).azure-corewas bumped to 1.31.0 in #29944.