[AKS] BREAKING CHANGE: Change: Default vm size changes to "" and clear test cases #31424
Conversation
Neo-MS
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Neo-MS, |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
customer-reported
microsoft-github-policy-service
bot
added
the
Compute
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please update your PR title according to https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#format-pr-title
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
Neo-MS
changed the title
Neo-MS
changed the title
|
As for the history note, please leave something like the following to the section History Notes in PR description. [AKS] BREAKING CHANGE:
|
| # vm size | ||
| CONST_DEFAULT_NODE_VM_SIZE = "Standard_DS2_v2" | ||
| CONST_DEFAULT_WINDOWS_NODE_VM_SIZE = "Standard_D2s_v3" | ||
| CONST_DEFAULT_NODE_VM_SIZE = "" |
There was a problem hiding this comment.
Since we're changing the behavior of the option, I think it would be a good idea to also change the help messsage for the option to remind the user that by default the server will help choose an appropriate vm size, but if the user specifies a vm size, it will be used.
Please search "--node-vm-size" in _help.py
There was a problem hiding this comment.
Thanks. PR description and the help info is added.
|
BTW, the PR description seems not to be correct, you're using |
Neo-MS
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Neo-MS
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Please remember to remove the original announcement in the PR #31056, because this announcement will expire |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@Neo-MS Could you please take a look at this comment #31424 (comment) |
@microsoft-github-policy-service agree company="microsoft" |
5 participants
Related command
az aks create
--resource-group myResourceGroup
--name myAKSCluster
--node-count 3
--node-vm-size Standard_DS3_v2
--enable-addons monitoring
--generate-ssh-keys
--location eastus
az aks nodepool add
--resource-group myResourceGroup
--cluster-name myAKSCluster
--name npuser01
--node-count 2
--node-vm-size Standard_D4s_v3
--os-type Linux
--mode User
originally, the default vmsize is Standard_DS2_v2 if user did not specified. In current, it will be selected by the backend.
History Notes
[AKS] BREAKING CHANGE:
az aks create: Change default value of option--node-vm-sizeto ""[AKS] BREAKING CHANGE:
az aks nodepool add: Change default value of option--node-vm-sizeto ""This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.