{Storage} Remove azure-mgmt-storage multiapi references #31526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account create | cmd storage account create update parameter account_type: added property choices=['Computer', 'User'] |
||
| storage account keys list | cmd storage account keys list update parameter expand: added property choices=['kerb'] |
||
| storage account update | cmd storage account update update parameter account_type: added property choices=['Computer', 'User'] |
||
| storage cors add | cmd storage cors add update parameter methods: added property choices=['CONNECT', 'DELETE', 'GET', 'HEAD', 'MERGE', 'OPTIONS', 'PATCH', 'POST', 'PUT', 'TRACE'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
calvinhzy
requested review from
bebound,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR removes outdated multiapi references for azure-mgmt-storage and updates version information in requirements and related test and command files. Key changes include:
- Upgrading azure-mgmt-storage version to 23.0.0 in requirements.
- Removing obsolete @api_version_constraint decorators and multiapi branching logic in tests and operations.
- Adjusting various CLI argument configurations to remove older min_api settings.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/requirements*.txt | Upgraded azure-mgmt-storage version from 22.1.0 to 23.0.0. |
| src/azure-cli/azure/cli/command_modules/storage/tests/* | Removed deprecated api_version_constraint decorators. |
| src/azure-cli/azure/cli/command_modules/storage/operations/blob.py | Removed multiapi branch to always use a single creation path. |
| src/azure-cli/azure/cli/command_modules/storage/commands.py | Removed min_api constraints for several commands. |
| src/azure-cli/azure/cli/command_modules/storage/_params.py | Cleared outdated min_api parameters for CLI arguments. |
| src/azure-cli-core/azure/cli/core/profiles/_shared.py | Updated default API version for storage; now set to None. |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/storage/operations/blob.py:71
- The removal of the multiapi branch bypasses the creation of a blob container using 'immutable_storage_with_versioning'. Ensure that eliminating this conditional check does not break functionality for environments that rely on that capability.
if cmd.supported_api_version(min_api='2019-06-01', resource_type=ResourceType.MGMT_STORAGE):
src/azure-cli-core/azure/cli/core/profiles/_shared.py:158
- The update sets the default API version for ResourceType.MGMT_STORAGE to None which contradicts the PR description that specifies retaining the latest API version (2024-01-01). Please confirm if this change is intended.
ResourceType.MGMT_STORAGE: None,
evelyn-ys
approved these changes
May 23, 2025
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Removing older api version references in azure-mgmt-storage as outlined below. Only keeping the latest api version now, which is 2024-01-01
Azure/azure-rest-api-specs#34681
https://github.com/Azure/sdk-release-request/issues/6211
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.