Skip to content

Conversation

@bebound
Copy link
Contributor

@bebound bebound commented Jul 31, 2025

Description

Changes:

  • Update setup.py to support 3.13
  • Add Python 3.13 full test
  • Change default Python version to 3.13 in CI

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 31, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 31, 2025

️✔️AzureCLI-BreakingChangeTest
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 31, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@bebound bebound marked this pull request as ready for review August 13, 2025 02:46
Copilot AI review requested due to automatic review settings August 13, 2025 02:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure CLI to support Python 3.13 by adding it as a supported programming language classifier in setup files and updating CI configurations to use Python 3.13 as the default version.

  • Add Python 3.13 support declarations to all setup.py files
  • Update CI pipeline configurations to use Python 3.13 as the default version
  • Update documentation to reflect Python 3.9-3.13 support range

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/azure-cli/setup.py Add Python 3.13 classifier
src/azure-cli-testsdk/setup.py Add Python 3.13 classifier
src/azure-cli-telemetry/setup.py Add Python 3.13 classifier
src/azure-cli-core/setup.py Add Python 3.13 classifier
scripts/regression_test/regression_test.yml Update Python version from 3.12 to 3.13
scripts/ci/test_extensions.sh Add serviceconnector-passwordless to ignore list and remove extension name from error message
doc/install_linux_prerequisites.md Update supported Python versions and remove Ubuntu 20.04 LTS
doc/extensions/authoring.md Update supported Python versions
doc/command_guidelines.md Update supported Python versions
azure-pipelines.yml Update Python version from 3.12 to 3.13 in CI jobs
azure-pipelines-full-tests.yml Update Python version from 3.9/3.12 to 3.12/3.13
.azure-pipelines/breaking-change-tests.yml Update Python version from 3.12 to 3.13

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

then
exit_code=1
echo "Failed to verify:" $ext
echo "Failed to verify"
Copy link

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message has been made less informative by removing the extension name variable. This makes debugging more difficult as it no longer indicates which specific extension failed verification.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ext is meaningless, it always points to last extension.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this line is copy-and-pasted from L55 without too much thinking.

Comment on lines -471 to -472
Python39:
python.version: '3.9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not drop Python 3.9's test as we need to make sure our code works on Python 3.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only test the Python which is used in official package.
Currently, RPM used 3.12, DEB, macOS and Windows use 3.13.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have removed 3.9's test in #31264.

@jiasli
Copy link
Member

jiasli commented Aug 13, 2025

No need to bump pylint and updating linter rules? We did a lot to support Python 3.12: #27673.

@bebound
Copy link
Contributor Author

bebound commented Aug 13, 2025

No need to bump pylint and updating linter rules? We did a lot to support Python 3.12: #27673.

There no major version bump in Pylint. Azdev is using the latest version.

     'pylint<4',

Source: https://github.com/Azure/azure-cli-dev-tools/blob/5130a24020ca0a47055e914a58a4af67d9eb98ad/setup.py#L76

@bebound bebound merged commit 77ef1c5 into Azure:dev Aug 20, 2025
90 checks passed
@bebound bebound deleted the support-3.13 branch August 21, 2025 03:43
bebound added a commit to bebound/azure-cli that referenced this pull request Oct 29, 2025
# Conflicts:
#	azure-pipelines-full-tests.yml
#	doc/command_guidelines.md
#	doc/extensions/authoring.md
#	doc/install_linux_prerequisites.md
#	scripts/regression_test/regression_test.yml
@bebound bebound mentioned this pull request Nov 17, 2025
29 tasks
bebound added a commit that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants