[Storage] Fix #32048: az storage blob sync: Fix using azcopy with account-key without login into azcli
#32127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
calvinhzy
changed the title
az storage blob sync: Fix case where user is not logged in but want to use azcopy with account-keyaz storage blob sync: Fix using azcopy with account-key without logging into azcli
calvinhzy
changed the title
az storage blob sync: Fix using azcopy with account-key without logging into azcliaz storage blob sync: Fix using azcopy with account-key without logging into azcli
calvinhzy
changed the title
az storage blob sync: Fix using azcopy with account-key without logging into azcliaz storage blob sync: Fix using azcopy with account-key without logging into azcli
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where az storage blob sync fails when using azcopy with account-key authentication without being logged into Azure CLI. The fix modifies the authentication logic to prevent attempting OAuth authentication when an account key is explicitly provided.
- Modified authentication logic to check if account-key credential is being used
- Updated comment to clarify the authentication preference behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
evelyn-ys
previously approved these changes
Sep 17, 2025
evelyn-ys
changed the title
az storage blob sync: Fix using azcopy with account-key without logging into azcliaz storage blob sync: Fix using azcopy with account-key without login into azcli
evelyn-ys
reviewed
Sep 17, 2025
| # prefer oauth mode | ||
| if client.credential: | ||
| # prefer oauth mode, if account-key is not provided | ||
| if client.credential and not hasattr(client.credential, "account_key"): |
Member
There was a problem hiding this comment.
Is it possible that client.credential is just a dict containing account_key so that hasattr() won't work?
Or is it possible that credential has sth else, eg SAS token or connection string so that no OAuth is needed?
…ssed in as a dict
evelyn-ys
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix #32048
az storage blob sync: Fix using azcopy with account-key without logging into azcliTesting Guide
History Notes
[Storage] Fix #32048:
az storage blob sync: Fix using azcopy with account-key without login into azcliThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.