Skip to content

[ACR] Improve error message in running acr login in cloud shell #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yugangw-msft merged 1 commit into from
Jan 19, 2018
Merged

[ACR] Improve error message in running acr login in cloud shell #5347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/command_modules/azure-cli-acr/azure/cli/command_modules/acr/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ def acr_update_set(cmd,


def acr_login(cmd, registry_name, resource_group_name=None, username=None, password=None):
from azure.cli.core.util import in_cloud_console
if in_cloud_console():
raise CLIError('This command requires running the docker daemon, which is not supported in Azure Cloud Shell.')

from subprocess import PIPE, Popen, CalledProcessError
docker_not_installed = "Please verify if docker is installed."
docker_not_available = "Please verify if docker daemon is running properly."
Expand Down