-
Notifications
You must be signed in to change notification settings - Fork 3.3k
On-board Maps #6303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
On-board Maps #6303
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
418b2a1
Introduce LocationBasedServices command_module
jp94 8bbcd51
Introduce test cases for LocationBasedServices command_module
jp94 18d9384
[Refactor] Renamed lbs to locationbasedservices
jp94 cb738db
[Refactor] Renamed lbs to locationbasedservices
jp94 b74cb79
[Legal] Add the Preview Terms agreement requirement
jp94 409b03b
[Test] Add more strict assertion rule for key validation.
jp94 ed3ca01
[Test] Add test for tags parameter
jp94 81e4fb5
[Test] Added an additional resource group.
jp94 0d11a6d
[Test] Init recordings
jp94 87accc7
Merge remote-tracking branch 'upstream/dev' into dev
jp94 9e5051f
[Pylint] Specify string format arguments as logging function parameters
jp94 77a9f22
[Refactor] Update description in _help to match the general template
jp94 98d973e
[Refactor] General template mismatch fix for 'key'
jp94 5853331
[Feature] Introduce search by ids
jp94 4d930f8
[Temporary] Throw an exception on 'account show' command, when nonexist
jp94 d36abf9
[Test] 'account show' on non-existent account should not return empty.
jp94 b79cb10
[Feature] Introduce update command
jp94 75795e6
[Test] Add test for update and search by id
jp94 100df29
Merge remote-tracking branch 'upstream/dev' into dev
jp94 1fd7bef
[Refactor] Rename generic client (sync with updated Swagger)
jp94 1aee6b2
[Refactor] Use default SDK's function
jp94 35976e7
[Refactor] Remove Preview Terms & docs in custom.py
jp94 e7784a1
[Maps] Rename LocationBasedServices to Maps
jp94 f9ca47d
[Maps] Use Maps SDK from LocationBasedServices SDK
jp94 52b9dde
[Maps] Update dependencies
jp94 c0c8bb8
[Maps] Resolving build error (doc_source_map)
jp94 498ca9c
Merge remote-tracking branch 'upstream/dev' into rename
jp94 4176c07
Merge remote-tracking branch 'upstream/dev' into rename
jp94 c6c5c02
[Maps] Resolving PR issues.
jp94 31f7a3a
[Maps] Revise help text
jp94 d49f8ad
[Maps] Adding back help docs for maps account
jp94 1f3d2c1
Merge remote-tracking branch 'upstream/dev' into rename
jp94 19b2fe9
[Load Test] replace sql with servicefabric
jp94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Maps] Resolving PR issues.
Removed validators.py. Will be adding checks in REST API specs and our backend routes to avoid redundancy. Updated azure_bdist_wheel.py Introduced minor fixes.
- Loading branch information
commit c6c5c02fd98c59b02109aebd6f48c9338d6e3242
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,17 +11,14 @@ | |
| resource_group_name_type, | ||
| tags_type) | ||
|
|
||
| from azure.cli.command_modules.maps.validators import validate_account_name | ||
| from azure.mgmt.maps.models.maps_management_client_enums import KeyType | ||
|
|
||
|
|
||
| def load_arguments(self, _): | ||
| # Argument Definition | ||
| maps_name_type = CLIArgumentType(options_list=['--name', '-n'], | ||
| completer=get_resource_name_completion_list( | ||
| 'Microsoft.Maps/accounts'), | ||
| help='The name of the Maps Account', | ||
| validator=validate_account_name) | ||
| completer=get_resource_name_completion_list('Microsoft.Maps/accounts'), | ||
| help='The name of the Maps Account') | ||
|
|
||
| # Parameter Registration | ||
| with self.argument_context('maps') as c: | ||
|
|
@@ -37,8 +34,7 @@ def load_arguments(self, _): | |
| c.argument('sku_name', | ||
| options_list=['--sku', '-s'], | ||
| help='The name of the SKU, in standard format (such as S0).', | ||
|
||
| arg_type=get_enum_type(['S0']), | ||
| required=False) | ||
| arg_type=get_enum_type(['S0'])) | ||
| c.argument('tags', | ||
| arg_type=tags_type) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 0 additions & 46 deletions
46
...odules/azure-cli-maps/azure/cli/command_modules/maps/tests/latest/test_maps_validators.py
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
src/command_modules/azure-cli-maps/azure/cli/command_modules/maps/validators.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase
mapsandaccount