Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
418b2a1
Introduce LocationBasedServices command_module
jp94 Feb 23, 2018
8bbcd51
Introduce test cases for LocationBasedServices command_module
jp94 Feb 23, 2018
18d9384
[Refactor] Renamed lbs to locationbasedservices
jp94 Feb 24, 2018
cb738db
[Refactor] Renamed lbs to locationbasedservices
jp94 Feb 24, 2018
b74cb79
[Legal] Add the Preview Terms agreement requirement
jp94 Feb 24, 2018
409b03b
[Test] Add more strict assertion rule for key validation.
jp94 Feb 26, 2018
ed3ca01
[Test] Add test for tags parameter
jp94 Feb 26, 2018
81e4fb5
[Test] Added an additional resource group.
jp94 Feb 26, 2018
0d11a6d
[Test] Init recordings
jp94 Feb 26, 2018
87accc7
Merge remote-tracking branch 'upstream/dev' into dev
jp94 Feb 26, 2018
9e5051f
[Pylint] Specify string format arguments as logging function parameters
jp94 Feb 26, 2018
77a9f22
[Refactor] Update description in _help to match the general template
jp94 Feb 27, 2018
98d973e
[Refactor] General template mismatch fix for 'key'
jp94 Feb 27, 2018
5853331
[Feature] Introduce search by ids
jp94 Feb 28, 2018
4d930f8
[Temporary] Throw an exception on 'account show' command, when nonexist
jp94 Feb 28, 2018
d36abf9
[Test] 'account show' on non-existent account should not return empty.
jp94 Feb 28, 2018
b79cb10
[Feature] Introduce update command
jp94 Mar 1, 2018
75795e6
[Test] Add test for update and search by id
jp94 Mar 1, 2018
100df29
Merge remote-tracking branch 'upstream/dev' into dev
jp94 Mar 20, 2018
1fd7bef
[Refactor] Rename generic client (sync with updated Swagger)
jp94 Mar 21, 2018
1aee6b2
[Refactor] Use default SDK's function
jp94 Mar 21, 2018
35976e7
[Refactor] Remove Preview Terms & docs in custom.py
jp94 Mar 21, 2018
e7784a1
[Maps] Rename LocationBasedServices to Maps
jp94 May 7, 2018
f9ca47d
[Maps] Use Maps SDK from LocationBasedServices SDK
jp94 May 7, 2018
52b9dde
[Maps] Update dependencies
jp94 May 7, 2018
c0c8bb8
[Maps] Resolving build error (doc_source_map)
jp94 May 7, 2018
498ca9c
Merge remote-tracking branch 'upstream/dev' into rename
jp94 May 8, 2018
4176c07
Merge remote-tracking branch 'upstream/dev' into rename
jp94 May 9, 2018
c6c5c02
[Maps] Resolving PR issues.
jp94 May 9, 2018
31f7a3a
[Maps] Revise help text
jp94 May 9, 2018
d49f8ad
[Maps] Adding back help docs for maps account
jp94 May 9, 2018
1f3d2c1
Merge remote-tracking branch 'upstream/dev' into rename
jp94 May 12, 2018
19b2fe9
[Load Test] replace sql with servicefabric
jp94 May 14, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Maps] Resolving PR issues.
Removed validators.py. Will be adding checks in REST API specs and our backend routes to avoid redundancy.

Updated azure_bdist_wheel.py
Introduced minor fixes.
  • Loading branch information
jp94 committed May 9, 2018
commit c6c5c02fd98c59b02109aebd6f48c9338d6e3242
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,14 @@
resource_group_name_type,
tags_type)

from azure.cli.command_modules.maps.validators import validate_account_name
from azure.mgmt.maps.models.maps_management_client_enums import KeyType


def load_arguments(self, _):
# Argument Definition
maps_name_type = CLIArgumentType(options_list=['--name', '-n'],
completer=get_resource_name_completion_list(
'Microsoft.Maps/accounts'),
help='The name of the Maps Account',
validator=validate_account_name)
completer=get_resource_name_completion_list('Microsoft.Maps/accounts'),
help='The name of the Maps Account')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase maps and account


# Parameter Registration
with self.argument_context('maps') as c:
Expand All @@ -37,8 +34,7 @@ def load_arguments(self, _):
c.argument('sku_name',
options_list=['--sku', '-s'],
help='The name of the SKU, in standard format (such as S0).',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove everything after the , - the valid values are enumerated in help.

arg_type=get_enum_type(['S0']),
required=False)
arg_type=get_enum_type(['S0']))
c.argument('tags',
arg_type=tags_type)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
logger = get_logger(__name__)


# pylint: disable=line-too-long
def create_account(client, resource_group_name, account_name, sku_name='S0', tags=None):
sku = Sku(name=sku_name)
maps_account_create_params = MapsAccountCreateParameters(location=ACCOUNT_LOCATION, sku=sku, tags=tags)
Expand Down

This file was deleted.

This file was deleted.

Loading