support vnet peering across tenant #6469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6469 +/- ##
===================================
Coverage 0% 0%
===================================
Files 11 11
Lines 133 133
Branches 9 9
===================================
Misses 133 133Continue to review full report at Codecov.
|
troydai
approved these changes
May 31, 2018
| identity_type, identity_id = Profile._try_parse_msi_account_name(account) | ||
|
|
||
| external_tenants_info = [] | ||
| for s in [x for x in (aux_subscriptions or []) if x != subscription_id]: |
Contributor
There was a problem hiding this comment.
it is more readable to use a longer variable name other than a single character.
| external_tenants_info = [] | ||
| for s in [x for x in (aux_subscriptions or []) if x != subscription_id]: | ||
| a = self.get_subscription(s) | ||
| if a[_TENANT_ID] != account[_TENANT_ID]: |
| def get_mgmt_service_client(cli_ctx, client_or_resource_type, subscription_id=None, api_version=None, | ||
| **kwargs): | ||
| aux_subscriptions=None, **kwargs): | ||
| ''' |
Contributor
There was a problem hiding this comment.
We use triple double quote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A scaled down version of #6423 with only vnet peering
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.