Allow one "bubble" in the perf script. #6470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #6224, #6218 and PR #6426.
We have a "perf bubble" in the CLI that, depending on the PR, moves between modules. Rather than chasing it by changing the threshold, this script allows one small bubble (<30 ms load time) to still pass, regardless of which module it is in. The second detected bubble will fail the script.
This should be a more stable workaround until the underlying cause is identified.
This checklist is used to make sure that common guidelines for a pull request are followed.
[N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
[N/A] I adhere to the Command Guidelines.