Skip to content

Conversation

@tjprescott
Copy link
Member

See issue #6224, #6218 and PR #6426.

We have a "perf bubble" in the CLI that, depending on the PR, moves between modules. Rather than chasing it by changing the threshold, this script allows one small bubble (<30 ms load time) to still pass, regardless of which module it is in. The second detected bubble will fail the script.

This should be a more stable workaround until the underlying cause is identified.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • [N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • [N/A] I adhere to the Command Guidelines.

@troydai troydai added this to the Sprint 38 milestone May 31, 2018
@codecov-io
Copy link

codecov-io commented May 31, 2018

Codecov Report

Merging #6470 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           dev   #6470   +/-   ##
===================================
  Coverage    0%      0%           
===================================
  Files       11      11           
  Lines      133     133           
  Branches     9       9           
===================================
  Misses     133     133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fa526...60341b0. Read the comment docs.

@troydai troydai merged commit 5fd6036 into Azure:dev May 31, 2018
@tjprescott tjprescott deleted the PerfScriptFix branch May 31, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants