Skip to content

BotService: fix tests, improve test robustness and update recordings #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjprescott merged 3 commits into from
Nov 29, 2018
Merged

BotService: fix tests, improve test robustness and update recordings #7941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c72ae6f
BotService: fix tests, mprove test robustness and update recordings
carlosscastro Nov 29, 2018
0b8fcbb
BotService; fixing tests
carlosscastro Nov 29, 2018
067d650
BotService: Update recordings
carlosscastro Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 59 additions & 51 deletions ...rvice/azure/cli/command_modules/botservice/tests/latest/recordings/test_auth_setting.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1,181 changes: 589 additions & 592 deletions .../cli/command_modules/botservice/tests/latest/recordings/test_create_v3_js_webapp_bot.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2,283 changes: 1,077 additions & 1,206 deletions ...ure/cli/command_modules/botservice/tests/latest/recordings/test_create_v3_webapp_bot.yaml
View file
Open in desktop

Large diffs are not rendered by default.

6,483 changes: 3,240 additions & 3,243 deletions .../cli/command_modules/botservice/tests/latest/recordings/test_create_v4_js_webapp_bot.yaml
View file
Open in desktop

Large diffs are not rendered by default.

317,534 changes: 158,696 additions & 158,838 deletions ...ure/cli/command_modules/botservice/tests/latest/recordings/test_create_v4_webapp_bot.yaml
View file
Open in desktop

Large diffs are not rendered by default.

125 changes: 65 additions & 60 deletions ...azure/cli/command_modules/botservice/tests/latest/recordings/test_directline_channel.yaml
View file
Open in desktop

Large diffs are not rendered by default.

119 changes: 62 additions & 57 deletions ...ce/azure/cli/command_modules/botservice/tests/latest/recordings/test_msteams_channel.yaml
View file
Open in desktop

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions ...sts/latest/recordings/test_prepare_publish_should_raise_cli_error_when_version_is_v4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
interactions:
- request:
body: '{"location": "westus", "tags": {"product": "azurecli", "cause": "automation",
"date": "2018-11-28T01:09:32Z"}}'
body: '{"tags": {"date": "2018-11-29T08:15:34Z", "product": "azurecli", "cause":
"automation"}, "location": "westus"}'
headers:
Accept: [application/json]
Accept-Encoding: ['gzip, deflate']
Expand All @@ -10,23 +10,23 @@ interactions:
Content-Length: ['110']
Content-Type: [application/json; charset=utf-8]
ParameterSetName: [--location --name --tag]
User-Agent: [python/3.7.0 (Windows-10-10.0.17763-SP0) msrest/0.6.1 msrest_azure/0.4.34
resourcemanagementclient/2.0.0 Azure-SDK-For-Python AZURECLI/2.0.51]
User-Agent: [python/3.5.2 (Windows-10-10.0.15063-SP0) msrest/0.6.2 msrest_azure/0.4.34
resourcemanagementclient/2.0.0 Azure-SDK-For-Python AZURECLI/2.0.52]
accept-language: [en-US]
method: PUT
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001?api-version=2018-05-01
response:
body: {string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001","name":"clitest.rg000001","location":"westus","tags":{"product":"azurecli","cause":"automation","date":"2018-11-28T01:09:32Z"},"properties":{"provisioningState":"Succeeded"}}'}
body: {string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001","name":"clitest.rg000001","location":"westus","tags":{"date":"2018-11-29T08:15:34Z","product":"azurecli","cause":"automation"},"properties":{"provisioningState":"Succeeded"}}'}
headers:
cache-control: [no-cache]
content-length: ['274']
content-type: [application/json; charset=utf-8]
date: ['Wed, 28 Nov 2018 01:09:32 GMT']
date: ['Thu, 29 Nov 2018 08:15:35 GMT']
expires: ['-1']
pragma: [no-cache]
strict-transport-security: [max-age=31536000; includeSubDomains]
x-content-type-options: [nosniff]
x-ms-ratelimit-remaining-subscription-writes: ['1199']
x-ms-ratelimit-remaining-subscription-writes: ['1198']
status: {code: 201, message: Created}
- request:
body: null
Expand All @@ -37,16 +37,16 @@ interactions:
Connection: [keep-alive]
Content-Length: ['0']
ParameterSetName: [-g -n]
User-Agent: [python/3.7.0 (Windows-10-10.0.17763-SP0) msrest/0.6.1 msrest_azure/0.4.34
azure-mgmt-botservice/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.51]
User-Agent: [python/3.5.2 (Windows-10-10.0.15063-SP0) msrest/0.6.2 msrest_azure/0.4.34
azure-mgmt-botservice/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.52]
accept-language: [en-US]
method: DELETE
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.BotService/botServices/cli000002?api-version=2018-07-12
response:
body: {string: ''}
headers:
cache-control: [no-cache]
date: ['Wed, 28 Nov 2018 01:09:33 GMT']
date: ['Thu, 29 Nov 2018 08:15:35 GMT']
expires: ['-1']
pragma: [no-cache]
strict-transport-security: [max-age=31536000; includeSubDomains]
Expand All @@ -62,16 +62,16 @@ interactions:
Connection: [keep-alive]
Content-Length: ['0']
ParameterSetName: [-g -n]
User-Agent: [python/3.7.0 (Windows-10-10.0.17763-SP0) msrest/0.6.1 msrest_azure/0.4.34
azure-mgmt-botservice/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.51]
User-Agent: [python/3.5.2 (Windows-10-10.0.15063-SP0) msrest/0.6.2 msrest_azure/0.4.34
azure-mgmt-botservice/0.1.0 Azure-SDK-For-Python AZURECLI/2.0.52]
accept-language: [en-US]
method: DELETE
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.BotService/botServices/cli000002?api-version=2018-07-12
response:
body: {string: ''}
headers:
cache-control: [no-cache]
date: ['Wed, 28 Nov 2018 01:09:34 GMT']
date: ['Thu, 29 Nov 2018 08:15:36 GMT']
expires: ['-1']
pragma: [no-cache]
strict-transport-security: [max-age=31536000; includeSubDomains]
Expand All @@ -88,8 +88,8 @@ interactions:
Content-Length: ['0']
Content-Type: [application/json; charset=utf-8]
ParameterSetName: [--name --yes --no-wait]
User-Agent: [python/3.7.0 (Windows-10-10.0.17763-SP0) msrest/0.6.1 msrest_azure/0.4.34
resourcemanagementclient/2.0.0 Azure-SDK-For-Python AZURECLI/2.0.51]
User-Agent: [python/3.5.2 (Windows-10-10.0.15063-SP0) msrest/0.6.2 msrest_azure/0.4.34
resourcemanagementclient/2.0.0 Azure-SDK-For-Python AZURECLI/2.0.52]
accept-language: [en-US]
method: DELETE
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001?api-version=2018-05-01
Expand All @@ -98,12 +98,12 @@ interactions:
headers:
cache-control: [no-cache]
content-length: ['0']
date: ['Wed, 28 Nov 2018 01:09:35 GMT']
date: ['Thu, 29 Nov 2018 08:15:36 GMT']
expires: ['-1']
location: ['https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/operationresults/eyJqb2JJZCI6IlJFU09VUkNFR1JPVVBERUxFVElPTkpPQi1DTElURVNUOjJFUkdIT1RRM0RDSVdMLVdFU1RVUyIsImpvYkxvY2F0aW9uIjoid2VzdHVzIn0?api-version=2018-05-01']
location: ['https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/operationresults/eyJqb2JJZCI6IlJFU09VUkNFR1JPVVBERUxFVElPTkpPQi1DTElURVNUOjJFUkdHS1JNMjZNRUJFLVdFU1RVUyIsImpvYkxvY2F0aW9uIjoid2VzdHVzIn0?api-version=2018-05-01']
pragma: [no-cache]
strict-transport-security: [max-age=31536000; includeSubDomains]
x-content-type-options: [nosniff]
x-ms-ratelimit-remaining-subscription-deletes: ['14999']
x-ms-ratelimit-remaining-subscription-deletes: ['14998']
status: {code: 202, message: Accepted}
version: 1
Loading