Skip to content

Query: Fixes LINQ ToString got absorbed during translation #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ealsur merged 13 commits into from
Oct 13, 2022
Merged

Query: Fixes LINQ ToString got absorbed during translation #3385

ealsur merged 13 commits into from
Oct 13, 2022

Conversation

@leminh98
Copy link
Contributor

@leminh98 leminh98 commented Aug 15, 2022 •
edited
Loading

Pull Request Template

Description

This PR fixes the issue of ToString got removed during the LINQ to SQL translation process.

Before: container.GetItemLinqQueryable().select(doc => doc.field_a.ToString()) will get translated to SELECT VALUE r.field_a FROM r
After: this query will translate to use the CosmosDB ToString function: SELECT VALUE ToString(r.field_a) FROM r

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

closes #3346

To automatically close an issue: closes #IssueNumber

adityasa
adityasa requested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

adityasa
adityasa approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

adityasa
adityasa reviewed Sep 20, 2022
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for a final review.

adityasa
adityasa requested changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for final review.

sboshra
sboshra previously approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ealsur ealsur enabled auto-merge (squash) October 10, 2022 21:32
@azure-pipelines
Copy link

azure-pipelines bot commented Oct 11, 2022

Command 'stop' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@leminh98
Copy link
Contributor Author

leminh98 commented Oct 11, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 11, 2022

Azure Pipelines successfully started running 1 pipeline(s).

adityasa
adityasa approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ealsur ealsur disabled auto-merge October 13, 2022 21:53
@ealsur ealsur merged commit 748f86c into master Oct 13, 2022
@ealsur ealsur deleted the users/leminh/LinqToStringFix branch October 13, 2022 21:53
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khdang khdang khdang left review comments

@adityasa adityasa adityasa approved these changes

@sboshra sboshra sboshra left review comments

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conversion error: ToString CosmosDb SQL function should be used

6 participants

@leminh98 @khdang @adityasa @sboshra @ealsur