Skip to content

Change Feed Processor: Fixes LeaseLostException leaks on notification APIs #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ealsur merged 6 commits into from
Aug 24, 2022
Merged

Change Feed Processor: Fixes LeaseLostException leaks on notification APIs #3401

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
841b420
Removes leaks
ealsur Aug 22, 2022
ddaca26
Tests
ealsur Aug 22, 2022
0664117
Fixing exception logging
ealsur Aug 23, 2022
d6c98c1
Using pattern matching
ealsur Aug 23, 2022
37939da
Comments
ealsur Aug 23, 2022
3a8fdd0
Merge branch 'master' into users/ealsur/leaselost
ealsur Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Using pattern matching
  • Loading branch information
@ealsur
ealsur committed Aug 23, 2022
commit d6c98c1f617e3c37e9889b741ee0d76acdafb461
24 changes: 13 additions & 11 deletions Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/FeedManagement/PartitionControllerCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,20 @@ public override async Task AddOrUpdateLeaseAsync(DocumentServiceLease lease)
catch (Exception ex)
{
await this.RemoveLeaseAsync(lease: lease, wasAcquired: false).ConfigureAwait(false);
if (ex is LeaseLostException leaseLostException)
switch (ex)
{
// LeaseLostException by itself is not loggable, unless it contains a related inner exception
// For cases when the lease or container has been deleted or the lease has been stolen
if (leaseLostException.InnerException != null)
{
await this.monitor.NotifyErrorAsync(lease.CurrentLeaseToken, leaseLostException.InnerException);
}
}
else
{
await this.monitor.NotifyErrorAsync(lease.CurrentLeaseToken, ex);
case LeaseLostException leaseLostException:
// LeaseLostException by itself is not loggable, unless it contains a related inner exception
// For cases when the lease or container has been deleted or the lease has been stolen
if (leaseLostException.InnerException != null)
{
await this.monitor.NotifyErrorAsync(lease.CurrentLeaseToken, leaseLostException.InnerException);
}
break;

default:
await this.monitor.NotifyErrorAsync(lease.CurrentLeaseToken, ex);
break;
}

throw;
Expand Down