Skip to content

[Internal] Client Telemetry: Fixes tests leaking environment variables #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirankumarkolli merged 17 commits into from
Oct 27, 2022
Merged

[Internal] Client Telemetry: Fixes tests leaking environment variables #3517

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7ba6980
Adding log lines
ealsur Oct 25, 2022
64ded36
More logs
ealsur Oct 25, 2022
01061db
Debugging further
ealsur Oct 25, 2022
c2afb58
Removing other builds
ealsur Oct 25, 2022
cd7b858
And more debugging
ealsur Oct 25, 2022
b37e020
Wrong build parameters
ealsur Oct 25, 2022
4f4a19b
Wrong category
ealsur Oct 25, 2022
4bcd86d
Removing noise
ealsur Oct 25, 2022
4210d44
Fixing test
ealsur Oct 26, 2022
19cbacf
Adding utils
ealsur Oct 27, 2022
623ccea
Adding test with client telemetry enabled
ealsur Oct 27, 2022
11bcada
Fixing leak in Client Telemetry Tests
ealsur Oct 27, 2022
103be56
Reenabling test
ealsur Oct 27, 2022
42e8ff7
cpu monitor initialization
ealsur Oct 27, 2022
e93b33c
Adding name details
ealsur Oct 27, 2022
de12438
Undo another file
ealsur Oct 27, 2022
d7a95c8
Merge branch 'master' into users/ealsur/syncontxt
ealsur Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding test with client telemetry enabled
  • Loading branch information
@ealsur
ealsur committed Oct 27, 2022
commit 623ccea9fb6613bbc527f74efd8151ef4c8fbb0b
50 changes: 24 additions & 26 deletions ...ft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/SynchronizationContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,24 @@
namespace Microsoft.Azure.Cosmos.SDK.EmulatorTests
{
using System;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using Microsoft.Azure.Cosmos.Linq;
using Microsoft.Azure.Cosmos.Services.Management.Tests;
using Microsoft.VisualStudio.TestTools.UnitTesting;

[TestClass]
public class SynchronizationContextTests
{
[TestMethod]
[DataTestMethod]
[DataRow(false, DisplayName = "Client Telemetry disabled")]
[DataRow(true, DisplayName = "Client Telemetry enabled")]
[Timeout(30000)]
public void VerifySynchronizationContextDoesNotLock()
public void VerifySynchronizationContextDoesNotLock(bool withClientTelemetry)
{
Type defaultTrace = Type.GetType("Microsoft.Azure.Cosmos.Core.Trace.DefaultTrace,Microsoft.Azure.Cosmos.Direct");
TraceSource traceSource = (TraceSource)defaultTrace.GetProperty("TraceSource").GetValue(null);
traceSource.Switch.Level = SourceLevels.All;
traceSource.Listeners.Clear();
traceSource.Listeners.Add(new ConsoleTraceListener());
if (withClientTelemetry)
{
Util.EnableClientTelemetryEnvironmentVariables();
}

string databaseId = Guid.NewGuid().ToString();
SynchronizationContext prevContext = SynchronizationContext.Current;
Expand All @@ -35,31 +34,27 @@ public void VerifySynchronizationContextDoesNotLock()
{
using (CosmosClient client = TestCommon.CreateCosmosClient())
{
Logger.LogLine("1");
Cosmos.Database database = client.CreateDatabaseAsync(databaseId).GetAwaiter().GetResult();
Logger.LogLine("a");
database = client.CreateDatabaseIfNotExistsAsync(databaseId).GetAwaiter().GetResult();
Logger.LogLine("b");
database.ReadStreamAsync().ConfigureAwait(false).GetAwaiter().GetResult();
Logger.LogLine("c");
database.ReadAsync().ConfigureAwait(false).GetAwaiter().GetResult();
Logger.LogLine("2");

QueryDefinition databaseQuery = new QueryDefinition("select * from T where T.id = @id").WithParameter("@id", databaseId);
FeedIterator<DatabaseProperties> databaseIterator = client.GetDatabaseQueryIterator<DatabaseProperties>(databaseQuery);
while (databaseIterator.HasMoreResults)
{
databaseIterator.ReadNextAsync().GetAwaiter().GetResult();
}
Logger.LogLine("3");

Container container = database.CreateContainerAsync(Guid.NewGuid().ToString(), "/pk").GetAwaiter().GetResult();
container = database.CreateContainerIfNotExistsAsync(container.Id, "/pk").GetAwaiter().GetResult();
Logger.LogLine("4");

ToDoActivity testItem = ToDoActivity.CreateRandomToDoActivity();
ItemResponse<ToDoActivity> response = container.CreateItemAsync<ToDoActivity>(item: testItem).ConfigureAwait(false).GetAwaiter().GetResult();
Assert.IsNotNull(response);
string diagnostics = response.Diagnostics.ToString();
Assert.IsTrue(diagnostics.Contains("Synchronization Context"));
Logger.LogLine("5");

using CancellationTokenSource cancellationTokenSource = new CancellationTokenSource();

try
Expand All @@ -76,7 +71,7 @@ public void VerifySynchronizationContextDoesNotLock()
string exception = oe.ToString();
Assert.IsTrue(exception.Contains("Synchronization Context"));
}
Logger.LogLine("6");

// Test read feed
container.GetItemLinqQueryable<ToDoActivity>(
allowSynchronousQueryExecution: true,
Expand All @@ -92,15 +87,15 @@ public void VerifySynchronizationContextDoesNotLock()
{
feedIterator.ReadNextAsync().GetAwaiter().GetResult();
}
Logger.LogLine("7");

FeedIterator<ToDoActivity> feedIteratorTyped = container.GetItemLinqQueryable<ToDoActivity>()
.ToFeedIterator<ToDoActivity>();

while (feedIteratorTyped.HasMoreResults)
{
feedIteratorTyped.ReadNextAsync().GetAwaiter().GetResult();
}
Logger.LogLine("8");

// Test query
container.GetItemLinqQueryable<ToDoActivity>(
allowSynchronousQueryExecution: true,
Expand All @@ -116,8 +111,6 @@ public void VerifySynchronizationContextDoesNotLock()
queryIterator.ReadNextAsync().GetAwaiter().GetResult();
}

Logger.LogLine("9");

FeedIterator<ToDoActivity> queryIteratorTyped = container.GetItemLinqQueryable<ToDoActivity>()
.Where(item => item.id != "").ToFeedIterator<ToDoActivity>();

Expand All @@ -126,30 +119,35 @@ public void VerifySynchronizationContextDoesNotLock()
queryIteratorTyped.ReadNextAsync().GetAwaiter().GetResult();
}

Logger.LogLine("10");

double costAsync = container.GetItemLinqQueryable<ToDoActivity>()
.Select(x => x.cost).SumAsync().GetAwaiter().GetResult();

double cost = container.GetItemLinqQueryable<ToDoActivity>(
allowSynchronousQueryExecution: true).Select(x => x.cost).Sum();
Logger.LogLine("11");

ItemResponse<ToDoActivity> deleteResponse = container.DeleteItemAsync<ToDoActivity>(partitionKey: new Cosmos.PartitionKey(testItem.pk), id: testItem.id).ConfigureAwait(false).GetAwaiter().GetResult();
Assert.IsNotNull(deleteResponse);
Logger.LogLine("12");
}
}, state: null);
}
finally
{
SynchronizationContext.SetSynchronizationContext(prevContext);

using (CosmosClient client = TestCommon.CreateCosmosClient())
{
client.GetDatabase(databaseId).DeleteAsync().GetAwaiter().GetResult();
}

if (withClientTelemetry)
{
Util.DisableClientTelemetryEnvironmentVariables();
}
}
}



public class TestSynchronizationContext : SynchronizationContext
{
private object locker = new object();
Expand Down