Skip to content

AI Integration: Adds public API for preview package #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sourabh1007 wants to merge 16 commits into from
Closed

AI Integration: Adds public API for preview package #3563

sourabh1007 wants to merge 16 commits into from

Conversation

@sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Nov 11, 2022 •
edited
Loading

Description

  1. This PR exposes opentelemetry/ AI Integration related flags publically for preview package.
  2. Remove EnableDiagnosticsTraceForAllRequests configuration.

AI SDK beta is already out with cosmosdb AI Integration related changes.

Type of change

  • [] New feature (non-breaking change which adds functionality)

@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/aiinterationenablereview branch from 0c5f83f to bee96e0 Compare November 11, 2022 21:40
kirankumarkolli
kirankumarkolli reviewed Nov 11, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 11, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 11, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 14, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 15, 2022
View reviewed changes
ealsur
ealsur previously approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get public API signoff. This PR might conflict with #3562, both are changing the same type and will trigger changes in contract

@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/aiinterationenablereview branch from 7a933b1 to 10c3cf4 Compare November 16, 2022 15:57
ealsur
ealsur reviewed Nov 16, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 16, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 16, 2022
View reviewed changes
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/aiinterationenablereview branch 2 times, most recently from 158bb2f to 159652a Compare November 18, 2022 16:22
kirankumarkolli
kirankumarkolli reviewed Nov 18, 2022
View reviewed changes
kirankumarkolli
kirankumarkolli reviewed Nov 18, 2022
View reviewed changes
kirankumarkolli
kirankumarkolli reviewed Nov 18, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 18, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 18, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 18, 2022
View reviewed changes
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/aiinterationenablereview branch from 798314d to 4899d6f Compare November 18, 2022 17:43
ealsur
ealsur reviewed Nov 18, 2022
View reviewed changes
ealsur
ealsur reviewed Nov 18, 2022
View reviewed changes
@sourabh1007 sourabh1007 marked this pull request as draft November 22, 2022 20:54
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/aiinterationenablereview branch from 161b64f to e714038 Compare November 22, 2022 21:45
@sourabh1007
Copy link
Contributor Author

sourabh1007 commented Dec 7, 2022

it is too old to rework. Creating new PR for this.

@sourabh1007 sourabh1007 closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealsur ealsur ealsur left review comments

@kirankumarkolli kirankumarkolli kirankumarkolli left review comments

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie will be requested when the pull request is marked ready for review Pilchie is a code owner

Assignees

No one assigned

Labels

Telemetry

Projects

Azure Cosmos SDKs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sourabh1007 @ealsur @kirankumarkolli