-
Notifications
You must be signed in to change notification settings - Fork 524
[Preview] Integrated cache: Adds BypassIntegratedCache to DedicatedGatewayRequestOptions #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
6 commits merged into
master
from
users/jiajunpeng-msft/addBypassingCacheOptionInDedicatedGatewayOptions
May 31, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
da0d0af
Integrated cache: Add BypassIntegratedCache to DedicatedGatewayReques…
jackiepmsft 1a40de7
Move this feature to public preview
jackiepmsft 5517289
Address comments
jackiepmsft 8b64d8f
Revert changes in EncryptionCustomAPI
jackiepmsft d55714f
Merge branch 'master' into users/jiajunpeng-msft/addBypassingCacheOpt…
jiajunpeng-msft 2d13041
Merge branch 'master' into users/jiajunpeng-msft/addBypassingCacheOpt…
ealsur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
...sts/Microsoft.Azure.Cosmos.Tests/Resource/Settings/DedicatedGatewayRequestOptionsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| namespace Microsoft.Azure.Cosmos.Tests.Resource.Settings | ||
| { | ||
| using Microsoft.Azure.Documents; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| [TestClass] | ||
| public class DedicatedGatewayRequestOptionsTests | ||
| { | ||
| [TestMethod] | ||
| public void BypassIntegratedCacheHeaderIsSetWhenTrue() | ||
| { | ||
| DedicatedGatewayRequestOptions dedicatedGatewayRequestOptions = new DedicatedGatewayRequestOptions | ||
| { | ||
| BypassIntegratedCache = true | ||
| }; | ||
|
|
||
| ItemRequestOptions itemRequestOptions = new ItemRequestOptions | ||
| { | ||
| DedicatedGatewayRequestOptions = dedicatedGatewayRequestOptions | ||
| }; | ||
|
|
||
| QueryRequestOptions queryRequestOptions = new QueryRequestOptions | ||
| { | ||
| DedicatedGatewayRequestOptions = dedicatedGatewayRequestOptions | ||
| }; | ||
|
|
||
| RequestMessage itemRequestMessage = new RequestMessage(); | ||
| RequestMessage queryRequestMessage = new RequestMessage(); | ||
|
|
||
| itemRequestOptions.PopulateRequestOptions(itemRequestMessage); | ||
| queryRequestOptions.PopulateRequestOptions(queryRequestMessage); | ||
|
|
||
|
|
||
| Assert.IsNotNull(itemRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
| Assert.IsNotNull(queryRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
|
|
||
| Assert.AreEqual("True", itemRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
| Assert.AreEqual("True", queryRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void BypassIntegratedCacheHeaderIsNotSetWhenFalse() | ||
| { | ||
| DedicatedGatewayRequestOptions dedicatedGatewayRequestOptions = new DedicatedGatewayRequestOptions | ||
| { | ||
| BypassIntegratedCache = false | ||
| }; | ||
|
|
||
| ItemRequestOptions itemRequestOptions = new ItemRequestOptions | ||
| { | ||
| DedicatedGatewayRequestOptions = dedicatedGatewayRequestOptions | ||
| }; | ||
|
|
||
| QueryRequestOptions queryRequestOptions = new QueryRequestOptions | ||
| { | ||
| DedicatedGatewayRequestOptions = dedicatedGatewayRequestOptions | ||
| }; | ||
|
|
||
| RequestMessage itemRequestMessage = new RequestMessage(); | ||
| RequestMessage queryRequestMessage = new RequestMessage(); | ||
|
|
||
| itemRequestOptions.PopulateRequestOptions(itemRequestMessage); | ||
| queryRequestOptions.PopulateRequestOptions(queryRequestMessage); | ||
|
|
||
|
|
||
| Assert.IsNull(itemRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
| Assert.IsNull(queryRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void BypassIntegratedCacheHeaderIsNotSetWhenNotSet() | ||
| { | ||
| ItemRequestOptions itemRequestOptions = new ItemRequestOptions | ||
| { | ||
| DedicatedGatewayRequestOptions = new DedicatedGatewayRequestOptions() | ||
| }; | ||
|
|
||
| QueryRequestOptions queryRequestOptions = new QueryRequestOptions | ||
| { | ||
| DedicatedGatewayRequestOptions = new DedicatedGatewayRequestOptions() | ||
| }; | ||
|
|
||
| RequestMessage itemRequestMessage = new RequestMessage(); | ||
| RequestMessage queryRequestMessage = new RequestMessage(); | ||
|
|
||
| itemRequestOptions.PopulateRequestOptions(itemRequestMessage); | ||
| queryRequestOptions.PopulateRequestOptions(queryRequestMessage); | ||
|
|
||
|
|
||
| Assert.IsNull(itemRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
| Assert.IsNull(queryRequestMessage.Headers[HttpConstants.HttpHeaders.DedicatedGatewayPerRequestBypassIntegratedCache]); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.