Skip to content

CosmosClientOptions: Adds support for multiple formats of Azure region names #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microsoft-github-policy-service merged 17 commits into from
Oct 10, 2023
Merged

CosmosClientOptions: Adds support for multiple formats of Azure region names #4016

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d2bc95d
Allow ComosClientOptions to take ApplicationRegion and ApplicationPre…
pradeep-chellappan-ds May 18, 2023
855e1ad
Merge branch 'master' into pradeepc/regionname-mapping
pradeep-chellappan May 18, 2023
7abed77
Address PR comment to avoid duplicating list of names.
pradeep-chellappan-ds May 18, 2023
91c5a62
Merge branch 'pradeepc/regionname-mapping' of https://github.com/prad…
pradeep-chellappan-ds May 18, 2023
2707eab
Remove the map table cache
Aug 2, 2023
63d2fd2
Only convert the region names when the client is initializing
Aug 4, 2023
53f7a4a
Update tests
Aug 4, 2023
d3efe96
Merge branch 'master' into dev/iainx/regionname-mapping
Aug 4, 2023
505ed0a
Make RegionNameMapper an instantiable class
Aug 25, 2023
35705a0
Remove debugging
Aug 25, 2023
c6ec852
Update tests to actually test things
Aug 25, 2023
534bf8a
Merge branch 'master' into dev/iainx/regionname-mapping
Aug 25, 2023
70c8c52
Merge branch 'master' into dev/iainx/regionname-mapping
Sep 12, 2023
8225e6c
Merge branch 'master' into dev/iainx/regionname-mapping
ealsur Sep 18, 2023
27d63c3
Merge branch 'master' into dev/iainx/regionname-mapping
Oct 3, 2023
7550eca
Merge branch 'master' into dev/iainx/regionname-mapping
kirankumarkolli Oct 9, 2023
fda51e7
Merge branch 'master' into dev/iainx/regionname-mapping
ealsur Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests to actually test things
  • Loading branch information
iain holmes committed Aug 25, 2023
commit c6ec85275f93dc81840230bc8ee1f7f0722535c5
19 changes: 7 additions & 12 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosClientOptionsUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,13 +579,16 @@ public void VerifyRegionNameFormatConversionBypassForApplicationRegion()
CosmosClientOptions cosmosClientOptions = new CosmosClientOptions();

// No conversion for expected format.
cosmosClientOptions.ApplicationRegion = Regions.AustraliaCentral2;
Assert.AreEqual(Regions.AustraliaCentral2, cosmosClientOptions.ApplicationRegion);
cosmosClientOptions.ApplicationRegion = Regions.NorthCentralUS;

// Ignore unknown values.
ConnectionPolicy policy = cosmosClientOptions.GetConnectionPolicy(0);

Assert.AreEqual(Regions.NorthCentralUS, policy.PreferredLocations[0]);

// Ignore unknown values.
cosmosClientOptions.ApplicationRegion = null;

ConnectionPolicy policy = cosmosClientOptions.GetConnectionPolicy(0);
policy = cosmosClientOptions.GetConnectionPolicy(0);

Assert.AreEqual(0, policy.PreferredLocations.Count);

Expand Down Expand Up @@ -652,14 +655,6 @@ public void VerifyRegionNameFormatConversionBypassForInvalidApplicationPreferred
{
CosmosClientOptions cosmosClientOptions = new CosmosClientOptions();

// List is null
cosmosClientOptions.ApplicationPreferredRegions = null;
Assert.IsNull(cosmosClientOptions.ApplicationRegion);

// List is empty
cosmosClientOptions.ApplicationPreferredRegions = new List<string>();
Assert.AreEqual(0, cosmosClientOptions.ApplicationPreferredRegions.Count);

// List contains valid and invalid values
cosmosClientOptions.ApplicationPreferredRegions = new List<string>
{
Expand Down