Skip to content

GlobalEndpointManager: Fixes Memory Leak #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microsoft-github-policy-service merged 6 commits into from
Dec 31, 2023
Merged

GlobalEndpointManager: Fixes Memory Leak #4226

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b946996
memory leak fix
NaluTripician Dec 23, 2023
88c5a3e
removed commented out code
NaluTripician Dec 23, 2023
3748630
changed to async so test would pass, with just static GetPropetiesHel…
NaluTripician Dec 24, 2023
21d8788
added thread saftey
NaluTripician Dec 27, 2023
37905c8
fixed to interlock pattern
NaluTripician Dec 28, 2023
9e605f5
Merge branch 'master' into users/nalutripician/cancellationTokenMemor…
kundadebdatta Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions Microsoft.Azure.Cosmos/src/Routing/GlobalEndpointManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,33 +114,35 @@ public Uri GetHubUri()
/// The 2 additional tasks will go through all the preferred regions in parallel
/// It will return the first success and stop the parallel tasks.
/// </summary>
public static Task<AccountProperties> GetDatabaseAccountFromAnyLocationsAsync(
public static async Task<AccountProperties> GetDatabaseAccountFromAnyLocationsAsync(
Uri defaultEndpoint,
IList<string>? locations,
Func<Uri, Task<AccountProperties>> getDatabaseAccountFn,
CancellationToken cancellationToken)
{
GetAccountPropertiesHelper threadSafeGetAccountHelper = new GetAccountPropertiesHelper(
{
using (GetAccountPropertiesHelper threadSafeGetAccountHelper = new GetAccountPropertiesHelper(
defaultEndpoint,
locations?.GetEnumerator(),
getDatabaseAccountFn,
cancellationToken);

return threadSafeGetAccountHelper.GetAccountPropertiesAsync();
cancellationToken))
{
return await threadSafeGetAccountHelper.GetAccountPropertiesAsync();
}
}

/// <summary>
/// This is a helper class to
/// </summary>
private class GetAccountPropertiesHelper
private class GetAccountPropertiesHelper : IDisposable
{
private readonly CancellationTokenSource CancellationTokenSource;
private readonly Uri DefaultEndpoint;
private readonly IEnumerator<string>? Locations;
private readonly Func<Uri, Task<AccountProperties>> GetDatabaseAccountFn;
private readonly List<Exception> TransientExceptions = new List<Exception>();
private AccountProperties? AccountProperties = null;
private Exception? NonRetriableException = null;
private Exception? NonRetriableException = null;
private int disposeCounter = 0;

public GetAccountPropertiesHelper(
Uri defaultEndpoint,
Expand Down Expand Up @@ -345,7 +347,16 @@ private static bool IsNonRetriableException(Exception exception)
}

return false;
}
}

public void Dispose()
{
if (Interlocked.Increment(ref this.disposeCounter) == 1)
{
this.CancellationTokenSource?.Cancel();
this.CancellationTokenSource?.Dispose();
}
}
}

public virtual Uri ResolveServiceEndpoint(DocumentServiceRequest request)
Expand Down