Skip to content

Diagnostics: Adds Client Configuration for Synchronization context cases #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microsoft-github-policy-service merged 3 commits into from
Mar 5, 2024
Merged

Diagnostics: Adds Client Configuration for Synchronization context cases #4338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
627cba6
disable network level tracing in sdk
sourabh1007 Feb 29, 2024
96ae87d
Revert "disable network level tracing in sdk"
sourabh1007 Mar 5, 2024
f253aab
Including Client Configuration in request Diagnostics for Sync calls …
sourabh1007 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Microsoft.Azure.Cosmos/src/Resource/ClientContextCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ private Task<TResult> OperationHelperWithRootTraceWithSynchronizationContextAsyn

using (ITrace trace = disableDiagnostics ? NoOpTrace.Singleton : (ITrace)Tracing.Trace.GetRootTrace(operationName, traceComponent, traceLevel))
{
trace.AddDatum("Client Configuration", this.client.ClientConfigurationTraceDatum);
trace.AddDatum("Synchronization Context", syncContextVirtualAddress);

return await this.RunWithDiagnosticsHelperAsync(
Expand Down
1 change: 1 addition & 0 deletions ...ft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/SynchronizationContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public void VerifySynchronizationContextDoesNotLock(bool withClientTelemetry)
Assert.IsNotNull(response);
string diagnostics = response.Diagnostics.ToString();
Assert.IsTrue(diagnostics.Contains("Synchronization Context"));
Assert.IsTrue(diagnostics.Contains("Client Configuration"));

using CancellationTokenSource cancellationTokenSource = new CancellationTokenSource();

Expand Down