-
Notifications
You must be signed in to change notification settings - Fork 527
Query: Adds support for non streaming ORDER BY #4362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
microsoft-github-policy-service
merged 36 commits into
master
from
users/ndeshpan/nonStreamingOrderBy
Apr 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
2d90f0f
Initial prep for adding a non streaming order by query pipline stage
neildsh 92a0625
Change TracingAsyncEnumerator to be an adapter class between ITracing…
neildsh 0eff840
Move TracingAsyncEnumerator to product code
neildsh 3ae0b62
Change ITracingAsyncEnumerator.MoveNext to take a CancellationToken, …
neildsh 0ff0687
draft implementation of non streaming order by pipeline stage
neildsh b252123
Fix bug that drops first record on an initialized page
neildsh 163f31f
Add a test class for non streaming order by unit tests
neildsh 83e1726
remove unnecessary usings
neildsh bf2e7dd
Add an emulator test for non streaming order by. Also lay groundwork …
neildsh 275b063
Remove the ResponseLengthInBytes property from QueryPage. This was be…
neildsh 94e3125
Add an ItemCount property to the Page class
neildsh 9eb7809
Add a multi level heap implementation for non streaming order by
neildsh ce69f9d
Add infrastructure for writing parity tests
neildsh 702c7ad
Fix a bug that caused the page enumerator to be dropped when we reach…
neildsh cb874da
When cloning OrderByQueryPartitionRangePageAsyncEnumerator as a fully…
neildsh 97d93d9
Simplify the non streaming pipeline stage, and add performance test
neildsh 075cb46
Revert the changes for Headers.ItemCount Keep it as a string
neildsh 1d02ee8
Avoid an allocation each time the OrderByItems property of OrderByQue…
neildsh 5f464d0
Fix up the OrderByPipelineSatgeBenchmark to use fully materialized Co…
neildsh 8089fdf
Add a few more unit tests for non streaming order by
neildsh 6e5a807
Add emulator tests for non streaming order by
neildsh 82bde9b
Add a few more integration test cases
neildsh be3fb81
Fix up broken unit test
neildsh c54e89b
Add more test coverage for the non streaming order by
neildsh 8babdb7
If there is no continuationtoken, assume that the response is streaming
neildsh 784295a
Add stronger validation to the non streaming order by unit tests
neildsh 98218bb
Fix up broken unit tests to account for ItemCount
neildsh 6b66ad2
fix up plumbing for index utilization, and incorporate code review fe…
neildsh 6abe501
Minor clean up
neildsh cf6f04b
revert bug introduced in pursuit of more elegant code :)
neildsh 3065ed1
fix up broken unit test
neildsh b966a8a
Fix up broken perf test
neildsh 3661c36
Fix up broken IndexMetricsParserBaselineTest
neildsh 74f3eff
Minor bug fixes for OrderByCrossPartitionEnumerator
neildsh 05befa6
Merge branch 'master' into users/ndeshpan/nonStreamingOrderBy
neildsh 2942dd1
Merge branch 'master' into users/ndeshpan/nonStreamingOrderBy
neildsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add an ItemCount property to the Page class
- Loading branch information
commit 94e3125edc4c70910ef13e80a8b8caab309fb194
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.