[Internal] Distributed Tracing: Fixes Client Config Test #4407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
FabianMeiswinkel,
adityasa,
ealsur,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
NaluTripician
approved these changes
Apr 11, 2024
philipthomas-MSFT
approved these changes
Apr 11, 2024
kirankumarkolli
requested changes
Apr 12, 2024
Member
kirankumarkolli
left a comment
kirankumarkolli
left a comment
There was a problem hiding this comment.
Please port the commit from master
Contributor
Author
|
@kirankumarkolli cherry-picked from master |
Member
|
Please check: #4408 (comment) |
Contributor
Author
|
Creating new PR |
auto-merge was automatically disabled
April 15, 2024 16:36
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the change?
Added "back", logic to generate activity id, even if customer is not subscribed to any source.
Why is change required?
As part of PR #4333, I removed network level traces generation, along with that, this code was also removed where we were making sure that traceid is generated, even if customer is not subscribed to the any traces.
Why was it not caught in PR pipelines?
It is part of emulator test, and we don't run emulator test in "preview" mode, in our PR pipelines.
Type of change
Closing issues
This would unblock 3.39.0 release