Skip to content

Conversation

@sourabh1007
Copy link
Contributor

Description

As part of this PR, providing Request Charge threshold and Payload load size threshold options to customers.It would generate request diagnostics if these thresholds were crossed,

Type of change

  • [] New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #4385

@sourabh1007 sourabh1007 marked this pull request as ready for review April 18, 2024 03:03
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/otelthresholdru branch from a1ca898 to a978141 Compare April 24, 2024 01:30
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only comment left is not regarding a change in this PR - but please let's discuss that one next week. Seem very odd to me.

@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/otelthresholdru branch from 680b56e to 23b3f99 Compare April 29, 2024 17:32
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sourabh1007 sourabh1007 added auto-merge Enables automation to merge PRs and removed auto-merge Enables automation to merge PRs labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Integration auto-merge Enables automation to merge PRs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Distributed Tracing: Add RequestChargeThreshold to CosmosThresholdOptions

7 participants