Skip to content

Conversation

@sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Aug 16, 2024

Description

ref #4553

  1. Operation Name List db.operation.name

Batch/bulk operations:
execute_batch
execute_bulk
batch_< operation name >
bulk_< operation name > (not covered yet)

Change feed operations:
query_change_feed

Conflicts operations:
delete_conflict
query_conflicts
read_all_conflicts
read_conflict

Container operations:
create_container
create_container_if_not_exists
delete_container
query_containers
read_all_containers
read_container
replace_container

Database operations:
create_database
create_database_if_not_exists
delete_database
query_databases
read_all_databases

Encryption key operations:
create_client_encryption_key
query_encryption_keys
read_all_encryption_keys
read_client_encryption_key
replace_client_encryption_key

Item operations:
create_item
delete_all_items_by_partition_key
delete_item
patch_item
query_items
read_all_items
read_all_items_of_logical_partition
read_many_items
read_item
replace_item
upsert_item

Permission operations:
create_permission
delete_permission
query_permissions
read_all_permissions
read_permission
replace_permission
upsert_permission

Stored procedure operations:
create_stored_procedure
delete_stored_procedure
execute_stored_procedure
query_stored_procedures
read_all_stored_procedures
read_stored_procedure
replace_stored_procedure

Throughput operations:
read_throughput
replace_throughput

Trigger operations:
create_trigger
delete_trigger
query_triggers
read_all_triggers
read_trigger
replace_trigger

User operations:
create_user
delete_user
query_users
read_all_users
read_user
replace_user
upsert_user

User-defined function operations:
create_user_defined_function
delete_user_defined_function
query_user_defined_functions
read_all_user_defined_functions
read_user_defined_function

  1. Fixed operation name generation for Batch.
  2. Appended bulk_ as prefix for operations
  3. Make sure diagnostic string and opentelemetry operation names are different

@sourabh1007 sourabh1007 changed the title Open Telemetry: Fixes Operation name to open follow Otel convention Open Telemetry: Fixes Operation name to follow Otel convention Aug 17, 2024
@sourabh1007 sourabh1007 marked this pull request as draft August 22, 2024 09:07
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/opentelemetryopsname branch 3 times, most recently from 080f87b to b323d28 Compare August 26, 2024 02:35
@sourabh1007 sourabh1007 marked this pull request as ready for review August 26, 2024 03:35
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/opentelemetryopsname branch from b323d28 to 782e521 Compare August 26, 2024 10:11
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

@sourabh1007 sourabh1007 self-assigned this Aug 27, 2024
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/opentelemetryopsname branch 5 times, most recently from 7fe48e2 to 7bc86d1 Compare September 1, 2024 01:54
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 6623de9 into master Sep 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/opentelemetryopsname branch September 18, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs Telemetry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants