Skip to content

Conversation

@changanhan
Copy link

Add FullTextIndexes to IndexingPolicy and add FullTextPolicy to ContainerProperties

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

public string Path { get; set; }

/// <summary>
/// Gets or sets a string containing the language of the full text path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a override for the container language?

#else
internal
#endif
Collection<FullTextIndexPath> FullTextIndexes { get; set; } = new Collection<FullTextIndexPath>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@kundadebdatta
Copy link
Member

Thanks @changanhan . I am working on taking this forward from here. Will submit a fresh PR and once merged, I will close this.

@changanhan
Copy link
Author

changanhan commented Oct 19, 2024 via email

@kundadebdatta
Copy link
Member

This was taken care by PR-4837. Hence closing this draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants