Skip to content

[Internal] JSON Binary Encoding: Adds support for encoding uniform arrays #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microsoft-github-policy-service merged 8 commits into from
Nov 5, 2024
Merged

[Internal] JSON Binary Encoding: Adds support for encoding uniform arrays #4866

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2fa187d
JSON Binary Encoding: Implement encoding of uniform number arrays and…
sboshra Nov 1, 2024
1f544ea
Updated argument check exceptions
sboshra Nov 1, 2024
28f14e1
Merge branch 'master' into users/sboshra/BinaryEncodingUniformArrays
sboshra Nov 1, 2024
c7f71ee
**JSON Test Updates**
sboshra Nov 4, 2024
ea755de
Merge branch 'master' of https://github.com/Azure/azure-cosmos-dotnet…
sboshra Nov 4, 2024
5858270
Merge branch 'users/sboshra/BinaryEncodingUniformArrays' of https://g…
sboshra Nov 4, 2024
a253020
Fixed build break in Microsoft.Azure.Cosmos.Performance.Tests project…
sboshra Nov 5, 2024
b018361
Added missing public XML comments to JsonWriteOptions enum.
sboshra Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated argument check exceptions
  • Loading branch information
@sboshra
sboshra committed Nov 1, 2024
commit 1f544ea3777fc3487d15441c99ed2a8facebf7e2
20 changes: 8 additions & 12 deletions Microsoft.Azure.Cosmos/src/Json/JsonWriter.JsonBinaryWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,15 +997,13 @@ static private bool TryWriteUniformNumberArray(
int valueLength,
int itemCount)
{
if (arrayWriter == null) throw new ArgumentNullException($"{nameof(arrayWriter)}");
if (arrayWriter == null) throw new ArgumentNullException(nameof(arrayWriter));
if (byteCount <= 0) throw new ArgumentException($"Value must be greater than 0.", nameof(byteCount));
if (valueLength <= 0) throw new ArgumentException($"Value must be greater than 0.", nameof(valueLength));

// Uniform arrays only support 1 and 2-byte item count
if (itemCount > ushort.MaxValue) return false;

// DOCDBASSERT(TypeMarker.IsArray(m_pbyBuffer[startOffset]));
// DOCDBASSERT(byteCount > 0);
// DOCDBASSERT(valueLength > 0);

int floatCount = 0;
long maxValue = long.MinValue;
long minValue = long.MaxValue;
Expand Down Expand Up @@ -1046,8 +1044,8 @@ static private bool TryWriteUniformNumberArray(
arrayBuffer = arrayBuffer.Slice(itemLength);
}

// DOCDBASSERT(numberValues.GetCount() == itemCount);
// DOCDBASSERT(itemCount >= floatCount);
// Assert(numberValues.Count == itemCount);
// Assert(itemCount >= floatCount);

byte itemTypeMarker;
int itemSize;
Expand Down Expand Up @@ -1179,16 +1177,14 @@ static private bool TryWriteUniformArrayOfNumberArrays(
int valueLength,
int itemCount)
{
if (arrayWriter == null) throw new ArgumentNullException($"{nameof(arrayWriter)}");
if (arrayWriter == null) throw new ArgumentNullException(nameof(arrayWriter));
if (byteCount <= 0) throw new ArgumentException($"Value must be greater than 0.", nameof(byteCount));
if (valueLength <= 0) throw new ArgumentException($"Value must be greater than 0.", nameof(valueLength));

// Uniform arrays only support 1 and 2-byte item count
if (itemCount > ushort.MaxValue) return false;
if (itemCount < 2) return false;

// DOCDBASSERT(TypeMarker::IsArray(m_pbyBuffer[nStartOffset]));
// DOCDBASSERT(nByteCount > 0);
// DOCDBASSERT(nValueLength > 0);

UniformArrayInfo commonArrayInfo = default;
int commonArrayLength = 0;

Expand Down