CrossRegionHedging: Fixes NullReference Exception Bug #4869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibahlfi
added
auto-merge
dibahlfi
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
kundadebdatta
previously approved these changes
Nov 5, 2024
Member
kundadebdatta
left a comment
kundadebdatta
left a comment
There was a problem hiding this comment.
One minor comment. Otherwise, LGTM.
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...t.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAvailabilityStrategyTests.cs
Outdated
Show resolved
Hide resolved
NaluTripician
requested changes
Nov 5, 2024
Contributor
NaluTripician
left a comment
NaluTripician
left a comment
There was a problem hiding this comment.
A few nits other than that LGTM. Good work, thanks!
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...t.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAvailabilityStrategyTests.cs
Outdated
Show resolved
Hide resolved
Contributor
|
We are changing the behavior here, previously if operation was cancelled due to cancellation token, it used to return a valid |
sourabh1007
reviewed
Nov 6, 2024
...soft.Azure.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionHedgingAvailabilityStrategy.cs
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Nov 14, 2024
NaluTripician
dismissed stale reviews from kirankumarkolli and themself
via
242cb11
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/AvailabilityStrategyUnitTests.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Jan 2, 2025
kirankumarkolli
approved these changes
Jan 2, 2025
NaluTripician
approved these changes
Jan 3, 2025
microsoft-github-policy-service
bot
deleted the
users/dibahlfi/HedgingCancellationTokenExcpetion
branch
kundadebdatta
pushed a commit
that referenced
this pull request
Jan 8, 2025
# Pull Request Template ## Description This change is to fix CosmosNullReferenceException that happens when a client passes a CancellationToken along with the request. Please see(#4737) for more information. ## Type of change Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #4737 --------- Co-authored-by: Arooshi Avasthy <[email protected]> Co-authored-by: Kiran Kumar Kolli <[email protected]> Co-authored-by: Nalu Tripician <[email protected]>
This was referenced Jan 8, 2025
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
# Pull Request Template ## Description This PR cherry-picks the following commits: - #4706 - #4869 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) ## Closing issues To automatically close an issue: closes #IssueNumber --------- Co-authored-by: Nalu Tripician <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]> Co-authored-by: Kevin Pilch <[email protected]> Co-authored-by: dibahlfi <[email protected]> Co-authored-by: Arooshi Avasthy <[email protected]> Co-authored-by: Kiran Kumar Kolli <[email protected]>
This was referenced Jul 28, 2025
Closed
This was referenced Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This change is to fix CosmosNullReferenceException that happens when a client passes a CancellationToken along with the request. Please see(#4737) for more information.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4737