Skip to content

[Internal] Binary Encoding: Fixes Performance Regression #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kundadebdatta wants to merge 7 commits into from
Closed

[Internal] Binary Encoding: Fixes Performance Regression #4884

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7230e75
Code changes to check perf regression fix.
kundadebdatta Nov 11, 2024
86d07c5
Code cleanup for serializers.
kundadebdatta Nov 11, 2024
7cc5ca5
Some more cleanup.
kundadebdatta Nov 11, 2024
d243843
Code changes to fix unit tests
kundadebdatta Nov 12, 2024
61ff215
Mode cleanup
kundadebdatta Nov 12, 2024
3adab73
Removing unnecessary print lines.
kundadebdatta Nov 12, 2024
11e41c6
Merge branch 'master' into users/dkunda/4644_binary_encoding_fix_perf…
kundadebdatta Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some more cleanup.
  • Loading branch information
@kundadebdatta
kundadebdatta committed Nov 11, 2024
commit 7cc5ca5ab47b6b159119a9d66a250ff93ea71485
8 changes: 0 additions & 8 deletions Microsoft.Azure.Cosmos/src/Handler/RequestInvokerHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,6 @@ public override async Task<ResponseMessage> SendAsync(
((CosmosTraceDiagnostics)response.Diagnostics).Value.AddOrUpdateDatum("ExcludedRegions", request.RequestOptions.ExcludeRegions);
}

//if (ConfigurationManager.IsBinaryEncodingEnabled()
// && RequestInvokerHandler.IsPointOperationSupportedForBinaryEncoding(request)
// && response.Content != null
// && response.Content is not CloneableStream)
//{
// response.Content = await StreamExtension.AsClonableStreamAsync(response.Content, default);
//}

return response;
}

Expand Down