Some more changes

Microsoft.Azure.Cosmos/src/DocumentClient.cs

@@ -477,7 +477,7 @@ internal DocumentClient(Uri serviceEndpoint,
                               RemoteCertificateValidationCallback remoteCertificateValidationCallback = null,
                               CosmosClientTelemetryOptions cosmosClientTelemetryOptions = null,
                               IChaosInterceptorFactory chaosInterceptorFactory = null,
-                              bool enableAsyncCacheExceptionNoSharing = false)
+                              bool enableAsyncCacheExceptionNoSharing = true)
         {
             if (sendingRequestEventArgs != null)
             {

Microsoft.Azure.Cosmos/src/Routing/AsyncCache.cs

@@ -20,7 +20,7 @@ namespace Microsoft.Azure.Cosmos.Common
     /// <typeparam name="TValue">Type of values.</typeparam>
     internal sealed class AsyncCache<TKey, TValue>
     {
-        private readonly bool isStackTraceOptimizationEnabled;
+        private readonly bool enableAsyncCacheExceptionNoSharing;
         private readonly IEqualityComparer<TValue> valueEqualityComparer;
         private readonly IEqualityComparer<TKey> keyEqualityComparer;
 
@@ -29,17 +29,17 @@ internal sealed class AsyncCache<TKey, TValue>
         public AsyncCache(
             IEqualityComparer<TValue> valueEqualityComparer,
             IEqualityComparer<TKey> keyEqualityComparer = null,
-            bool enableStackTraceOptimization = false)
+            bool enableAsyncCacheExceptionNoSharing = true)
         {
             this.keyEqualityComparer = keyEqualityComparer ?? EqualityComparer<TKey>.Default;
             this.values = new ConcurrentDictionary<TKey, AsyncLazy<TValue>>(this.keyEqualityComparer);
             this.valueEqualityComparer = valueEqualityComparer;
-            this.isStackTraceOptimizationEnabled = enableStackTraceOptimization;
+            this.enableAsyncCacheExceptionNoSharing = enableAsyncCacheExceptionNoSharing;
         }
 
-        public AsyncCache(bool enableStackTraceOptimization = false)
+        public AsyncCache(bool enableStackTraceOptimization = true)
             : this(valueEqualityComparer: EqualityComparer<TValue>.Default,
-                  enableStackTraceOptimization: enableStackTraceOptimization)
+                  enableAsyncCacheExceptionNoSharing: enableStackTraceOptimization)
         {
         }
 

Microsoft.Azure.Cosmos/src/Routing/AsyncCacheNonBlocking.cs

@@ -20,7 +20,7 @@ namespace Microsoft.Azure.Cosmos
     /// </summary>
     internal sealed class AsyncCacheNonBlocking<TKey, TValue> : IDisposable
     {
-        private readonly bool isStackTraceOptimizationEnabled;
+        private readonly bool enableAsyncCacheExceptionNoSharing;
         private readonly CancellationTokenSource cancellationTokenSource;
         private readonly ConcurrentDictionary<TKey, AsyncLazyWithRefreshTask<TValue>> values;
         private readonly Func<Exception, bool> removeFromCacheOnBackgroundRefreshException;
@@ -32,21 +32,21 @@ public AsyncCacheNonBlocking(
             Func<Exception, bool> removeFromCacheOnBackgroundRefreshException = null,
             IEqualityComparer<TKey> keyEqualityComparer = null,
             CancellationToken cancellationToken = default,
-            bool enableAsyncCacheExceptionNoSharing = false)
+            bool enableAsyncCacheExceptionNoSharing = true)
         {
             this.keyEqualityComparer = keyEqualityComparer ?? EqualityComparer<TKey>.Default;
             this.values = new ConcurrentDictionary<TKey, AsyncLazyWithRefreshTask<TValue>>(this.keyEqualityComparer);
             this.removeFromCacheOnBackgroundRefreshException = removeFromCacheOnBackgroundRefreshException ?? AsyncCacheNonBlocking<TKey, TValue>.RemoveNotFoundFromCacheOnException;
             this.cancellationTokenSource = cancellationToken == default
                 ? new CancellationTokenSource()
                 : CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
-            this.isStackTraceOptimizationEnabled = enableAsyncCacheExceptionNoSharing;
+            this.enableAsyncCacheExceptionNoSharing = enableAsyncCacheExceptionNoSharing;
         }
 
-        public AsyncCacheNonBlocking(bool enableStackTraceOptimization = false)
+        public AsyncCacheNonBlocking(bool enableAsyncCacheExceptionNoSharing = true)
             : this(removeFromCacheOnBackgroundRefreshException: null,
                   keyEqualityComparer: null,
-                  enableAsyncCacheExceptionNoSharing: enableStackTraceOptimization)
+                  enableAsyncCacheExceptionNoSharing: enableAsyncCacheExceptionNoSharing)
         {
         }
 

Microsoft.Azure.Cosmos/src/Routing/CollectionCache.cs

@@ -29,15 +29,15 @@ internal abstract class CollectionCache
         protected class InternalCache
         {
             internal InternalCache(
-                bool enableStackTraceOptimization)
+                bool enableAsyncCacheExceptionNoSharing)
             {
                 this.collectionInfoByName = new AsyncCache<string, ContainerProperties>(
                     new CollectionRidComparer(),
-                    enableStackTraceOptimization: enableStackTraceOptimization);
+                    enableAsyncCacheExceptionNoSharing: enableAsyncCacheExceptionNoSharing);
 
                 this.collectionInfoById = new AsyncCache<string, ContainerProperties>(
                     new CollectionRidComparer(),
-                    enableStackTraceOptimization: enableStackTraceOptimization);
+                    enableAsyncCacheExceptionNoSharing: enableAsyncCacheExceptionNoSharing);
 
                 this.collectionInfoByNameLastRefreshTime = new ConcurrentDictionary<string, DateTime>();
                 this.collectionInfoByIdLastRefreshTime = new ConcurrentDictionary<string, DateTime>();
@@ -56,11 +56,11 @@ internal InternalCache(
         protected readonly InternalCache[] cacheByApiList;
 
         protected CollectionCache(
-            bool enableStackTraceOptimization)
+            bool enableAsyncCacheExceptionNoSharing)
         {
             this.cacheByApiList = new InternalCache[2];
-            this.cacheByApiList[0] = new InternalCache(enableStackTraceOptimization); // for API version < 2018-12-31
-            this.cacheByApiList[1] = new InternalCache(enableStackTraceOptimization); // for API version >= 2018-12-31
+            this.cacheByApiList[0] = new InternalCache(enableAsyncCacheExceptionNoSharing); // for API version < 2018-12-31
+            this.cacheByApiList[1] = new InternalCache(enableAsyncCacheExceptionNoSharing); // for API version >= 2018-12-31
         }
 
         /// <summary>

Microsoft.Azure.Cosmos/src/Routing/GatewayAddressCache.cs

@@ -72,14 +72,14 @@ public GatewayAddressCache(
             long suboptimalPartitionForceRefreshIntervalInSeconds = 600,
             bool enableTcpConnectionEndpointRediscovery = false,
             bool replicaAddressValidationEnabled = false,
-            bool enableStackTraceOptimization = false)
+            bool enableAsyncCacheExceptionNoSharing = true)
         {
             this.addressEndpoint = new Uri(serviceEndpoint + "/" + Paths.AddressPathSegment);
             this.protocol = protocol;
             this.tokenProvider = tokenProvider;
             this.serviceEndpoint = serviceEndpoint;
             this.serviceConfigReader = serviceConfigReader;
-            this.serverPartitionAddressCache = new AsyncCacheNonBlocking<PartitionKeyRangeIdentity, PartitionAddressInformation>(enableStackTraceOptimization);
+            this.serverPartitionAddressCache = new AsyncCacheNonBlocking<PartitionKeyRangeIdentity, PartitionAddressInformation>(enableAsyncCacheExceptionNoSharing);
             this.suboptimalServerPartitionTimestamps = new ConcurrentDictionary<PartitionKeyRangeIdentity, DateTime>();
             this.serverPartitionAddressToPkRangeIdMap = new ConcurrentDictionary<ServerKey, HashSet<PartitionKeyRangeIdentity>>();
             this.suboptimalMasterPartitionTimestamp = DateTime.MaxValue;

Microsoft.Azure.Cosmos/src/Routing/GlobalAddressResolver.cs

@@ -39,7 +39,7 @@ internal sealed class GlobalAddressResolver : IAddressResolverExtension, IDispos
         private readonly ConcurrentDictionary<Uri, EndpointCache> addressCacheByEndpoint;
         private readonly bool enableTcpConnectionEndpointRediscovery;
         private readonly bool isReplicaAddressValidationEnabled;
-        private readonly bool enableStackTraceOptimization;
+        private readonly bool enableAsyncCacheExceptionNoSharing;
         private readonly IConnectionStateListener connectionStateListener;
         private IOpenConnectionsHandler openConnectionsHandler;
 
@@ -54,7 +54,7 @@ public GlobalAddressResolver(
             ConnectionPolicy connectionPolicy,
             CosmosHttpClient httpClient,
             IConnectionStateListener connectionStateListener,
-            bool enableStackTraceOptimization = false)
+            bool enableAsyncCacheExceptionNoSharing = true)
         {
             this.endpointManager = endpointManager;
             this.partitionKeyRangeLocationCache = partitionKeyRangeLocationCache;
@@ -74,7 +74,7 @@ public GlobalAddressResolver(
 
             this.isReplicaAddressValidationEnabled = ConfigurationManager.IsReplicaAddressValidationEnabled(connectionPolicy);
 
-            this.enableStackTraceOptimization = enableStackTraceOptimization;
+            this.enableAsyncCacheExceptionNoSharing = enableAsyncCacheExceptionNoSharing;
 
             this.maxEndpoints = maxBackupReadEndpoints + 2; // for write and alternate write endpoint (during failover)
 
@@ -349,7 +349,7 @@ private EndpointCache GetOrAddEndpoint(Uri endpoint)
                         this.connectionStateListener,
                         enableTcpConnectionEndpointRediscovery: this.enableTcpConnectionEndpointRediscovery,
                         replicaAddressValidationEnabled: this.isReplicaAddressValidationEnabled,
-                        enableStackTraceOptimization: this.enableStackTraceOptimization);
+                        enableAsyncCacheExceptionNoSharing: this.enableAsyncCacheExceptionNoSharing);
 
                     string location = this.endpointManager.GetLocation(endpoint);
                     AddressResolver addressResolver = new AddressResolver(null, new NullRequestSigner(), location);

Microsoft.Azure.Cosmos/src/Routing/GlobalEndpointManager.cs

@@ -45,7 +45,7 @@ internal class GlobalEndpointManager : IGlobalEndpointManager
         public GlobalEndpointManager(
             IDocumentClientInternal owner,
             ConnectionPolicy connectionPolicy,
-            bool enableStackTraceOptimization = false)
+            bool enableAsyncCacheExceptionNoSharing = true)
         {
             this.locationCache = new LocationCache(
                 new ReadOnlyCollection<string>(connectionPolicy.PreferredLocations),
@@ -59,7 +59,7 @@ public GlobalEndpointManager(
             this.connectionPolicy = connectionPolicy;
 
             this.connectionPolicy.PreferenceChanged += this.OnPreferenceChanged;
-            this.databaseAccountCache = new AsyncCache<string, AccountProperties>(enableStackTraceOptimization);
+            this.databaseAccountCache = new AsyncCache<string, AccountProperties>(enableAsyncCacheExceptionNoSharing);
 
 #if !(NETSTANDARD15 || NETSTANDARD16)
 #if NETSTANDARD20

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Routing/AsyncCacheNonBlockingTests.cs

@@ -28,7 +28,7 @@ public class AsyncCacheNonBlockingTests
         [ExpectedException(typeof(NotFoundException))]
         public async Task ValidateNegativeScenario(bool forceRefresh)
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             await asyncCache.GetAsync(
                 "test",
                 async (_) =>
@@ -42,7 +42,7 @@ await asyncCache.GetAsync(
         [TestMethod]
         public async Task ValidateMultipleBackgroundRefreshesScenario()
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
 
             string expectedValue = "ResponseValue";
             string response = await asyncCache.GetAsync(
@@ -75,7 +75,7 @@ public async Task ValidateMultipleBackgroundRefreshesScenario()
         [ExpectedException(typeof(NotFoundException))]
         public async Task ValidateNegativeNotAwaitedScenario()
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             Task task1 = asyncCache.GetAsync(
                 "test",
                 async (_) =>
@@ -105,7 +105,7 @@ await asyncCache.GetAsync(
         public async Task ValidateNotFoundOnBackgroundRefreshRemovesFromCacheScenario()
         {
             string value1 = "Response1Value";
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             string response1 = await asyncCache.GetAsync(
                 "test",
                 async (_) =>
@@ -171,7 +171,7 @@ await asyncCache.GetAsync(
         [Owner("jawilley")]
         public async Task ValidateAsyncCacheNonBlocking()
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             string result = await asyncCache.GetAsync(
                 "test",
                 (_) => Task.FromResult("test2"),
@@ -212,7 +212,7 @@ public async Task ValidateAsyncCacheNonBlocking()
         [Owner("jawilley")]
         public async Task ValidateCacheValueIsRemovedAfterException()
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             string result = await asyncCache.GetAsync(
                 key: "test",
                 singleValueInitFunc: (_) => Task.FromResult("test2"),
@@ -268,7 +268,7 @@ await asyncCache.GetAsync(
         [Owner("jawilley")]
         public async Task ValidateConcurrentCreateAsyncCacheNonBlocking()
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             int totalLazyCalls = 0;
 
             List<Task> tasks = new List<Task>();
@@ -292,7 +292,7 @@ public async Task ValidateConcurrentCreateAsyncCacheNonBlocking()
         [Owner("jawilley")]
         public async Task ValidateConcurrentCreateWithFailureAsyncCacheNonBlocking()
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             int totalLazyCalls = 0;
 
             Random random = new Random();
@@ -331,7 +331,7 @@ await asyncCache.GetAsync(
         [Owner("jawilley")]
         public async Task ValidateExceptionScenariosCacheNonBlocking()
         {
-            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new AsyncCacheNonBlocking<string, string>(enableAsyncCacheExceptionNoSharing: false);
             int totalLazyCalls = 0;
 
             try
@@ -402,7 +402,7 @@ await asyncCache.GetAsync(
         public async Task Refresh_WhenRefreshRequestedForAnExistingKey_ShouldRefreshTheCache()
         {
             // Arrange.
-            AsyncCacheNonBlocking<string, string> asyncCache = new (enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new (enableAsyncCacheExceptionNoSharing: false);
 
             // Act and Assert.
             string result = await asyncCache.GetAsync(
@@ -437,7 +437,7 @@ await Task.Delay(
         public async Task Refresh_WhenThrowsDocumentClientException_ShouldRemoveKeyFromTheCache()
         {
             // Arrange.
-            AsyncCacheNonBlocking<string, string> asyncCache = new (enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new (enableAsyncCacheExceptionNoSharing: false);
 
             // Act and Assert.
             string result = await asyncCache.GetAsync(
@@ -491,7 +491,7 @@ await Task.Delay(
         public async Task Refresh_WhenThrowsOtherException_ShouldNotRemoveKeyFromTheCache()
         {
             // Arrange.
-            AsyncCacheNonBlocking<string, string> asyncCache = new (enableStackTraceOptimization: false);
+            AsyncCacheNonBlocking<string, string> asyncCache = new (enableAsyncCacheExceptionNoSharing: false);
 
             // Act and Assert.
             string result = await asyncCache.GetAsync(