-
Notifications
You must be signed in to change notification settings - Fork 525
TokenCredentialCache: Adds an options to override AAD audience scope. #5252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TokenCredentialCache: Adds an options to override AAD audience scope. #5252
Conversation
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
...zure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Utils/LocalEmulatorTokenCredential.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosAuthorizationTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline - there should be zero knowledge of DNS name for fabric endings and special casing of audiences in the SDK.
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosAuthorizationTests.cs
Outdated
Show resolved
Hide resolved
|
Please update title |
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks
Pull Request Template
Description
Add AAD audience scope override functionality when this environment variable is set AADScopeOverride = "AZURE_COSMOS_AAD_SCOPE_OVERRIDE". If no environment variable is et then it uses the existing default scope value.
This will help clients in accessing applications which have a different scope.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber