Fixes attribute names as per OTel Semantic Conventions #5472
Conversation
joegoldman2
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
| /// Represents the unique identifier of the client instance. | ||
| /// </summary> | ||
| public const string ClientId = "azure.cosmosdb.client.id"; | ||
| public const string ClientId = "azure.client.id"; |
There was a problem hiding this comment.
I don't think we can just replace the attribute names - this would be a breakign change. Instead populating attributes with both names seems the appropriate way. Maybe we can add an opt-in to allow only populating teh new names if a customer explicitly opt-in into it for perf reasons.
FabianMeiswinkel
left a comment
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
The current change is a breaking behavior change
|
@FabianMeiswinkel thank you for the review. Is the support for OpenTelemetry already stable in this lib? As far as I know, it's not yet stable and something like Also, such changes have already been made in the past (#4995 or #4765 for example). |
2 participants
db.system.namevaluecosmosdb=>azure.cosmosdbazure.cosmosdb.client.id=>azure.client.idazure.cosmosdb.request.request_charge=>azure.cosmosdb.operation.request_chargeazure.cosmosdb.contacted_regions=>azure.cosmosdb.operation.contacted_regionsazure.cosmosdb.row.count=>db.response.returned_rowsTested manually with both the Application Insights SDK and OpenTelemetry SDK.