Binary Encoding: Adds support to DateTimeOffset type in CosmosDBNewtonsoftWriter #5474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meghana-Palaparthi
requested review from
FabianMeiswinkel,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Json/NewtonsoftInteropTests.cs
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kirankumarkolli
previously approved these changes
Nov 5, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kundadebdatta
added
auto-merge
kirankumarkolli
approved these changes
Nov 10, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kirankumarkolli
changed the title
Meghana-Palaparthi
deleted the
5473_add_datetimeoffset_to_cosmosDBToNewtonsoftWriter
branch
This was referenced Nov 29, 2025
Merged
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During some of the internal customer (IC3) validation, it was identified that when the Cosmos .Net SDK is initialized with binary encoding, and a
DateTimeOffsetfield is passed in the payload, the serialization layer is unable to parse the field and hence fails the operation.This PR fixes the serialization gap by extending support to
DateTimeOffsettype inCosmosDBNewtonsoftWriterType of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5473