Skip to content

Conversation

@Jackbk
Copy link
Contributor

@Jackbk Jackbk commented Apr 14, 2020


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.

@Jackbk Jackbk marked this pull request as ready for review April 14, 2020 22:45
@Jackbk Jackbk requested a review from digimaun as a code owner April 14, 2020 22:45
Jackbk and others added 3 commits April 14, 2020 15:45
ghost
ghost previously approved these changes Apr 21, 2020
@Jackbk Jackbk dismissed ghost ’s stale review via d0b15b6 April 28, 2020 17:36
@Jackbk
Copy link
Contributor Author

Jackbk commented Apr 28, 2020

Updated tests:
image

ghost
ghost previously approved these changes Apr 28, 2020
@Jackbk Jackbk dismissed ghost ’s stale review via dc2a8f7 April 28, 2020 19:29
@ghost
Copy link

ghost commented Apr 28, 2020

image

@digimaun digimaun self-assigned this Apr 29, 2020
@digimaun digimaun merged commit 8f9bd05 into Azure:dev Apr 29, 2020
c-ryan-k pushed a commit to c-ryan-k/azure-iot-cli-extension that referenced this pull request Apr 10, 2025
* Add support for dataprocessor destination type

* refactor and unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants