Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 2, 2020


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.

@ghost ghost requested a review from digimaun as a code owner May 2, 2020 01:38
self.provisioned = device.get("provisioned")
self.simulated = device.get("simulated")
self.device_status = self._parse_device_status()
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unneeded pass

@digimaun digimaun merged commit ec60169 into Azure:dev May 2, 2020
c-ryan-k pushed a commit to c-ryan-k/azure-iot-cli-extension that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant