Skip to content

Conversation

@vilit1
Copy link
Contributor

@vilit1 vilit1 commented Feb 24, 2021

Replace logic for replace tag with if-none-match


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have you made an entry in HISTORY.rst which concisely explains your feature or change?

@vilit1 vilit1 requested a review from digimaun as a code owner February 24, 2021 23:45
help="Indicates the operation should replace an existing twin if it exists."
"if_none_match",
options_list=["--if-none-match"],
help="Indicates the create operation should fail an existing twin if it exists."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this a bit more clear: "Indicates the create operation should fail if an existing twin with the same id exists."

@digimaun
Copy link
Member

Let's add at least one command example & description for each command that can make use of --if-none-match or --etag

https://github.com/vilit1/azure-iot-cli-extension/blob/if_none_match/azext_iot/digitaltwins/_help.py

@digimaun
Copy link
Member

Let's add an integration test to exercise --if-none-match for az dt twin relationship create

@vilit1
Copy link
Contributor Author

vilit1 commented Feb 25, 2021

image

@digimaun digimaun merged commit 65028a5 into Azure:dev Feb 25, 2021
@vilit1 vilit1 deleted the if_none_match branch April 19, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants