test (azure-iot-device) : DPS cert management client cert issuance tests #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivakar
changed the title
Member
cartertinney
left a comment
cartertinney
left a comment
There was a problem hiding this comment.
Is there a reason this newly generated service client is here rather than in the dev_utils package? Feels more appropriate to be there, given the size of the thing.
azure-iot-device/samples/dps-cert-mgmt/provision_symmetric_key_client_cert_issuance.py
Outdated
Show resolved
Hide resolved
tests/e2e/provisioning_e2e/tests/test_sync_symmetric_enrollments.py
Outdated
Show resolved
Hide resolved
| linked_iot_hub = connection_string_to_hostname(os.getenv("IOTHUB_CONNECTION_STRING")) | ||
| # TODO Delete this line. This is a pre created variable in key vault now. | ||
| symmetric_key_for_cert_management = os.getenv("DPS_CERT_ISSUANCE_SYM_KEY_SYNC") | ||
| connection_string = os.getenv("IOTHUB_CONNECTION_STRING") |
Member
There was a problem hiding this comment.
Outside the scope of this PR, but at some point we should probably try and overhaul these DPS E2Es to use some of the enhancements and shared infrastructure Bert created for IoTHub E2Es + stress tests.
Probably can wait til V3 though
|
Ship it. |
anthonyvercolano
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some portions of provisioning service SDK which was used for tests have been utilized for the tests.
Our dependency is now only on ms-rest.