[DoNotMerge] CDN experiment #187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hovsepm Hey Hovsep. This pull request is the result of auto-generating the CDN service client from its latest swagger. Can you take a look and make sure that everything looks correct from a CDN perspective? |
ghost
approved these changes
Mar 7, 2018
ghost
requested review from
hovsepm and
milismsft
and removed request for
milismsft
|
Everything looks good, but some of the test recordings are failing. I'm going to close (not merge) this PR. |
ghost
closed this
praries880
pushed a commit
that referenced
this pull request
May 1, 2019
* Fixing BatchAIJob refresh functionality * Skip for the test * Updating test
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@daschult That's the result of the SwaggerToSdk conf we have based on latest CDN in this PR:
Azure/azure-rest-api-specs#2514
I used the SwaggerToSdk CLI:
Could you check if it's fair, meaning diff can be explained ONLY by:
If you see something obviously wrong that comes from a configuration issue, please reach out to me. The plan is to fix the PR 2514 until this Java is is a good shape. When we reach that, we know the system is ready (whatever the real planning).
Thanks!
FYI @salameer