Skip to content

Added zones to top level allowed properties #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veronicagg merged 2 commits into from
Nov 3, 2017
Merged

Added zones to top level allowed properties #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83898e7
Added `zones` to top level allowed properties
mcardosos Oct 31, 2017
f0e1e23
Added zones in many many places
mcardosos Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...dotnet/OpenAPI.Validator.Tests/Resource/OpenAPI/Validation/body-top-level-properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"swagger": "2.0",
"info": {
"title": "Top level properties allowed for models allOf Resource in body parameters are name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity.",
"title": "Top level properties allowed for models allOf Resource in body parameters are name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones.",
"description": "Some documentation.",
"version": "2017-02-08"
},
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/OpenAPI.Validator/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/dotnet/OpenAPI.Validator/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@
<value>Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: {0}</value>
</data>
<data name="AllowedTopLevelProperties" xml:space="preserve">
<value>Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity. Model definition '{0}' has extra properties ['{1}'].</value>
<value>Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition '{0}' has extra properties ['{1}'].</value>
</data>
<data name="TrackedResourceGetOperationMissing" xml:space="preserve">
<value>Tracked resource '{0}' must have a get operation.</value>
Expand Down
2 changes: 1 addition & 1 deletion src/dotnet/OpenAPI.Validator/Validation/BodyTopLevelProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class BodyTopLevelProperties : TypedRule<Dictionary<string, Schema>>

private static readonly IEnumerable<string> AllowedTopLevelProperties = new List<string>()
{ "name", "type", "id", "location", "properties", "tags", "plan", "sku", "etag",
"managedBy", "identity", "kind"};
"managedBy", "identity", "kind", "zones"};

/// <summary>
/// Id of the Rule.
Expand Down